From ba9a7a47d96fece88831f29d71da2a65397a90c0 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 27 Jun 2024 10:01:45 +0100 Subject: [PATCH] Bug 36128: (QA follow-up) Add regression test This patch adds a simple regression test to ensure we don't re-introduce the errant warning. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer (cherry picked from commit 18c97c1456b527521624fc9be6f8c3bacaba28f1) Signed-off-by: Lucas Gass (cherry picked from commit ed17a680acb74cfd3496ec97c70610fea846f8a9) Signed-off-by: Fridolin Somers --- t/db_dependent/Overdues.t | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t index 13da09b341..af719faf76 100755 --- a/t/db_dependent/Overdues.t +++ b/t/db_dependent/Overdues.t @@ -1,7 +1,7 @@ #!/usr/bin/perl; use Modern::Perl; -use Test::More tests => 17; +use Test::More tests => 18; use Test::Warn; use C4::Context; @@ -84,6 +84,11 @@ is_deeply( $mtts, ['print', 'sms', 'email'], 'GetOverdueMessageTransportTypes: t # Test GetBranchcodesWithOverdueRules $dbh->do(q|DELETE FROM overduerules|); + +my @overdue_branches; +warnings_are { @overdue_branches = C4::Overdues::GetBranchcodesWithOverdueRules(); } [], + "No warnings thrown when no overdue rules exist"; + $dbh->do(q| INSERT INTO overduerules ( branchcode,categorycode, delay1,letter1,debarred1, delay2,letter2,debarred2, delay3,letter3,debarred3 ) @@ -93,7 +98,7 @@ $dbh->do(q| my @branchcodes = map { $_->branchcode } Koha::Libraries->search->as_list; -my @overdue_branches = C4::Overdues::GetBranchcodesWithOverdueRules(); +@overdue_branches = C4::Overdues::GetBranchcodesWithOverdueRules(); is_deeply( [ sort @overdue_branches ], [ sort @branchcodes ], 'If a default rule exists, all branches should be returned' ); $dbh->do(q| -- 2.39.5