From 998fb79cb353868d55edba29064b1fb2cace2008 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 3 Jun 2022 08:29:19 +0200 Subject: [PATCH] Bug 31319: Remove GetItemsInfo from tags/list.pl Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered. Here we are going to deal with tags/list Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt | 5 +++-- tags/list.pl | 9 ++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt index cc25b9f11d..70904be156 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt @@ -1,6 +1,7 @@ [% USE raw %] [% USE Asset %] [% USE AuthorisedValues %] +[% USE Branches %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] [% IF ( do_it ) %]Review[% ELSE %]Review tags[% END %] › Tags › Tools › Koha @@ -64,9 +65,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : [% END %]

[% END %] - [% IF ( title.items ) %]
    [% FOREACH item IN title.items %] + [% IF ( title.items.count ) %]
      [% FOREACH item IN title.items %]
    • - [% item.branchname | html %] + [% Branches.GetName(item.holdingbranch) | html %] [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) | html %] diff --git a/tags/list.pl b/tags/list.pl index ac2ccbc8b1..b9aec1aa19 100755 --- a/tags/list.pl +++ b/tags/list.pl @@ -23,10 +23,11 @@ use CGI qw ( -utf8 ); use C4::Auth qw( get_template_and_user ); use C4::Biblio qw( GetBiblioData ); use C4::Context; -use C4::Items qw( GetItemsInfo ); use C4::Tags qw( get_tag_rows get_tags remove_tag ); use C4::Output qw( output_html_with_http_headers ); +use Koha::Biblios; + my $needed_flags = { tools => 'moderate_tags' }; # FIXME: replace when more specific permission is created. @@ -57,11 +58,13 @@ else { if ($tag) { my $taglist = get_tag_rows( { term => $tag } ); for ( @{$taglist} ) { + # FIXME We should use Koha::Biblio here my $dat = &GetBiblioData( $_->{biblionumber} ); - my @items = GetItemsInfo( $_->{biblionumber} ); + my $biblio = Koha::Biblios->find($dat->{biblionumber}); + my $items = $biblio->items->search_ordered; $dat->{biblionumber} = $_->{biblionumber}; $dat->{tag_id} = $_->{tag_id}; - $dat->{items} = \@items; + $dat->{items} = $items; $dat->{TagLoop} = get_tags( { biblionumber => $_->{biblionumber}, -- 2.39.5