From af9938c43feaa76bf1b1bb0a0e4b21ff7fbbe449 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 22 Sep 2020 14:14:55 +0000 Subject: [PATCH] Bug 26507: Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- Koha/Item.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 8b7a12653f..add258491e 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -113,9 +113,6 @@ sub store { $self->cn_sort($cn_sort); } - C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) - unless $params->{skip_modzebra_update}; - logaction( "CATALOGUING", "ADD", $self->itemnumber, "item" ) if $log_action && C4::Context->preference("CataloguingLog"); @@ -189,9 +186,6 @@ sub store { $self->paidfor(''); } - C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) - unless $params->{skip_modzebra_update}; - logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " . Dumper($self->unblessed) ) if $log_action && C4::Context->preference("CataloguingLog"); } @@ -201,6 +195,8 @@ sub store { } my $result = $self->SUPER::store; + C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) + unless $params->{skip_modzebra_update}; $self->get_from_storage->_after_item_action_hooks({ action => $plugin_action }); return $result; -- 2.39.5