Jonathan Druart jonathan.druart
  • Joined on Sep 03, 2020
Loading Heatmap…

jonathan.druart pushed to master at Koha-community/Koha

  • c5b715a853 Bug 23271: Fix random failure from Categories.t # Failed test 'The branch limitation should have been stored and retrieved' # at t/db_dependent/Koha/Patron/Categories.t line 57. # Structures begin differing at: # $got->[0] = 'fm0A1a' # $expected->[0] = 'vNquBvCa' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

2 hours ago

jonathan.druart pushed to master at Koha-community/Koha

  • dd3b509d55 Bug 23271: Fix Template/Plugin/Branches.t # Failed test 'Without selected parameter, my library should be preselected' # at t/db_dependent/Template/Plugin/Branches.t line 81. # got: '0' # expected: '1' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

2 hours ago

jonathan.druart pushed to master at Koha-community/Koha

  • feaeff330c Bug 27644: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 58c275e04b Bug 23583: Handle OpacHiddenItems with yaml_preference This patch makes all places in Koha that rely on OpacHiddenItems actually use C4::Context->yaml_preference instead of manually calling the YAML libraries and handling it. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Items* \ t/db_dependent/Koha/Item* \ t/db_dependent/Koha/Filter/EmbedItems.t => SUCCESS: Tests pass! 3. Try hiding things with opac-ISBDdetail.pl and opac-search.pl => SUCCESS: Things work the same! 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 1bb9b8b551 Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • a01f7fac96 Bug 28086: OpacMaintenance page should use ReplytoDefault if set This patch changes the OPAC maintenance template so that it checks for a value in the ReplyToDefault system preference when displaying the "please contact the site administrator" email link. Also changed: If neither ReplytoDefault nor KohaAdminEmailAddress is defined, it won't show the link at all. To test, apply the patch and set the OpacMaintenance preference to "Show." - In the OPAC you should see the "System Maintenance" page. - Test this page with various settings: - ReplytoDefault and KohaAdminEmailAddress both populated. - Only ReplytoDefault - Only KohaAdminEmailAddress - Neither. Confirm that the correct email address is used in each case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • c1c2872440 Bug 27644: (QA follow-up) Remove size=1 from template Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 50 commits »

4 hours ago

jonathan.druart pushed to master at Koha-community/Koha

  • 99c10bf448 Bug 27830: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 953088f816 Bug 27830: (follow-up) Merge DE and FR address formats Library addresses don't include the use of "Street Type" and "Street Number." DE and FR address formats differ only in the position of street type and number in the address sequence. This patch merges DE and FR address markup and uses the unified block if the address format system preference ISN'T "us". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • e1e309c628 Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 55b050b607 Bug 27282: fix all occurrences This patch fixes all the occurrences, staff and OPAC. The problem only happens on some versions of Chrome. TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open -Go to cgi-bin/koha/sco/sco-main.pl in Chrome, make sure you can finish and print successfully -In the staff client in Chrome makes sure printing works in the following areas: 1. /cgi-bin/koha/circ/circulation.pl Print Slip and Print Quick Slip 2. /cgi-bin/koha/members/boraccount.pl Make a payment and make sure you can print the invoice 3. cgi-bin/koha/labels/spinelabel-home.pl Make a quick spine label in Chrome and make sure that prints. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • fae72d031a Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 23 commits »

8 hours ago

jonathan.druart pushed to master at Koha-community/Koha

  • f964efacb9 Bug 27836: Document that CirControl changes which calendar is being used You can verify that which branch's Koha calendar is being used to calculate fines by reading for example the code in C4::Circulation::_CalculateAndUpdateFine() There you can see that $control_branchcode variable is being passed to C4::Overdues::CalcFine() and if you trace that you will see in the end it decides which branch's calendar to use for calculating chargeable overdue fine days. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • e62687a1df Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • df71a27a66 Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • d60439b96a Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page This patch adds a label to the sort function on the OPAC results page to provide context to screen readers and improve accessibility. The label is visually hidden and does not change how the page displays. To test: - Search for something on the OPAC - Change how the results are sorted and confirm sort still works - Confirm that there are no visual changes to the page - Inspect the sort function to confirm it now has a label - Ideally confirm the label works with a screenreader Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 21ddbae735 Bug 26679: Use index-term-genre for 655 To test: 1 - have a bib with a 655 that is not linked to an authority 2 - confirm link on OPAC and intranet details uses subject index 3 - apply patch, restart, reload pages 4 - confirm links now use index-term-genre and give correct results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 16 commits »

5 days ago

jonathan.druart pushed to master at Koha-community/Koha

  • e0b0e908f7 Bug 15986: Add missing notice template for it-IT Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

5 days ago

jonathan.druart pushed to master at Koha-community/Koha

  • bb83da9b1d Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9c4f99bee97e97c85643896 It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated. Compare with both existing records to see which the 3rd has been matched against. 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • cb0f279390 Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration Like for MARC21, UNIMARC authorities has subdivisions form, general, chronological and geographic. In C4::Heading::UNIMARC, use subdivisions in _get_search_heading like in C4::Heading::MARC21. Adds subdivisions variables into UNIMARC authorities zebra configuration. Note that unlike MARC21 geographic is subfield $y and chronological is subfield $z. See https://www.ifla.org/publications/unimarc-formats-and-related-documentation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 051a9d740f Bug 15986: DBRev 20.12.00.032 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 1e44788d8c Bug 15986: move holds_reminder.pl to misc/cronjobs/holds/ Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 3314c0bf0f Bug 15986: (follow-up) Switch nomail to confirm Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 25 commits »

5 days ago

jonathan.druart pushed to master at Koha-community/Koha

  • 0da874bde2 Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri To test: 1) Go to Admin -> system preferences and enable the TrackClicks syspref (set to Track or Track anonymously) 2) Find a record in the staff client with an item. Edit the item and put two external URLs in the Uniform Resource Identifier field, e.g. "https://www.google.com/ | https://twitter.com/" 3) Search for that record in the OPAC. Notice the two links in the holdings table. 4) Click a link and confirm that you are directed to a 404. 5) Apply the patch and refresh the page 6) Click a link and confirm that you are directed to the page as expected 7) Go back to edit the record in the staff client and remove one of the links from the URI field 8) Go back to the OPAC and confirm you can still access the link as expected when there is only one URI Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 559950cae6 Bug 28123: Fix expected value in unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 52f997fcfc Bug 28123: Quote filename value in Content-Disposition header Chrome throws a ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION error if a Content-Disposition header includes an unquoted filename that contains commas. This patch adds quotes around the filename in the Content-Disposition header, which fixes the problem. Test plan: 0. Do not apply the patch yet 1. Obtain a PDF and rename it to include a comma in its name 2. Enable the upload.pl plugin in the 856$u of the Default framework 3. Add/edit a record in the Default Framework and upload a file using the 856$u upload plugin. 4. Click on the resulting file URL in the saved file 5. Note the error ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION is returned instead of the file 6. Apply the patch and restart your Plack instance 7. Click on the resulting file URL in the saved file 8. Note that you now get the PDF file instead of the error Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 54c5ee5706 Bug 28103: Fix barcode plugin on the order receive view Fix the following error: Uncaught TypeError: Cannot read property 'field_value' of null Test plan: Set "AcqCreateItem" to "receiving an order" Set "autoBarcode" to "generated in the form <branchcode>yymm0001" Create an order and go to receive it at a path like /cgi-bin/koha/acqui/orderreceive.pl?ordernumber=2&invoiceid=1 Click on the barcode input and confirm that it's prefilled automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 71574961f7 Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 28125: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 24 commits »

5 days ago

jonathan.druart pushed to master at Koha-community/Koha

  • 9d7f55a874 Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 49a795ceb3 Bug 21260: DBRev 20.12.00.031 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • b795660540 Bug 21260: (follow-up) Consolidate preference The bug added a local preference. This should now become a real one. Renamed in the process to better reflect its use. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 871a2fc6ff Bug 21549: DBRev 20.12.00.030 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • b010b69052 Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 25 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 4625df3228 Bug 28055: (follow-up) Revert changes to aoColumnDefs option name This patch undoes changes to two lines in columns_settings.inc which were triggering unwanted side-effects. There are several templates and JavaScript files which use "aoColumnDefs" to pass options to columns settings, and if we change this file without changing those at the same time things will break. When these lines are updated it must be done so at the same time as we modify the templates which pass that same option. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • aa71e7132c Bug 14233: Set default for NoticesLog to 0 To prevent a warning on the about page: System preference 'NoticesLog' must be '0' or '1', but is ''. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 5a3a9a17c6 Bug 27069: (follow-up) Only display rules if one is set Testing that the rule is != 'hold_allowed' is true for each itemtype where the rule is not set. This means it appears that no holds are allowed for any item type if no rules are set To test: 1 - With a fresh testing DB or no holdallowed rule set, you can use SQl below to clear: DELETE from circuation_rules WHERE rule_name='holdallowed'; 2 - Load smart-rules.pl (Administration->Circulation and fines rules) 3 - Scroll to "Default holds policy by item type" 4 - Note all item types appear as 'No holds allowed' 5 - Apply patch 6 - Reload 7 - All clear 8 - Confirm adding rules displays correctly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 3 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 65542edbe0 Bug 27839: (follow-up) Update docs for koha-worker Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 90291914f9 Bug 27839: Add tab-completion in bash for koha-worker This patch simply adds tab-completion for this script. To test: 1. Apply this patch 2. Run: $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common 3. Open a new bash instance 4. Type 'koha-worker <tab>' => SUCCESS: All options are there 5. Play with Koha instances => SUCCESS: they show up, once chosen they are not offered anymore 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 14d843f5f4 Bug 24695: (QA follow-up) Fix POD Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 48ac552699 Bug 24695: Move to Koha::Report->is_sql_valid Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • ba5be802e0 Bug 24695: Improve SQL report validation The saved SQL report code validates the SQL in multiple places: when saving, when updating, and when executing the query. Move the validation code into Koha::Reports, and write tests for it. Test plan: 1) Apply patch 2) Create a new valid SQL report, save it (success) 3) Create a new illegal SQL report, try to save (fails) 4) Update already saved SQL report by adding one of the forbidden words, eg. delete or drop (saving will fail) 5) Edit a save_sql in the database, changing it to eg. "drop borrowers", and try to execute it (fails) 6) Prove t/db_dependent/Koha/Reports.t Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no qa errors. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 24695: (QA follow-up) Fix number of tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 12 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 031dd035ab Bug 27857: Fix Pseudonymization.t t/db_dependent/Koha/Pseudonymization.t .. 2/3 # Failed test 'Attribute 1 should be retrieved correctly' # at t/db_dependent/Koha/Pseudonymization.t line 198. # Structures begin differing at: # $got->{borrowernumber} = Does not exist # $expected->{borrowernumber} = '58' # Failed test 'Attribute 2 should be retrieved correctly' # at t/db_dependent/Koha/Pseudonymization.t line 204. # Structures begin differing at: # $got->{borrowernumber} = Does not exist # $expected->{borrowernumber} = '58' # Looks like you failed 2 tests of 3. t/db_dependent/Koha/Pseudonymization.t .. 3/3 Highlighted by commit 7b40ee22035210e3fbdfe75785d68ca314285409 Bug 27857: Make Koha::Patron->extended_attributes validate data Koha::Patron->add_extended_attributes should not modify the $attribute hashref parameter we passed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 5f25235b9e Bug 25476: Add ability to browse file uploads by category This patch adds the ability to search/browse files by category. (Note it doesn't include temporary uploads since they don't have a "category" per se.) Test Plan: 0) Apply patch 1) Go to /cgi-bin/koha/admin/authorised_values.pl 2) Create "UPLOAD" authorized value category 3) Create "test" authorized value in "UPLOAD" category 4) Go to /cgi-bin/koha/tools/upload.pl 5) Note "Search uploads by category" fieldset 6) Upload new file to "test" category 7) Click "Back" 8) Choose "test" category in "Search uploads by category" 9) Click "Search" 10) Note that your file upload is displayed in result list Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • aad8699b01 Bug 14233: DBRev 20.12.00.028 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 5e5f65863d Bug 14233: Select the correct tab Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 058884ed4f Bug 14233: Add logging support to notices and slips management This enhancements adds support for logging changes to notices and slips. Features include: - a system preference (NoticesLog) which allows you to enable logging changes for notices and slips - logging new notices, changes to notices, and deletion of notices - filtering in the log viewer so you can show all changes for a specific notice - a comparison feature, so you can see what changes were made to a notice. Test plan: 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 00ec2839ce Bug 14233: DB changes - NoticesLog pref + letter.id PK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 30 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • a26303138c Bug 22773: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 7b7937f3e5 Bug 22773: (follow-up) Fix id clash and data element Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 72ce742597 Bug 22773: Assign different id to checkboxes Otherwise clicking the label does not work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • ca2028d0e7 Bug 22773: (follow-up) Ensure buttons only affect their related table Also cleans up a few rebase issues Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • fc4e1b513c Bug 22773: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 11 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 4bfc2584e0 Bug 27069: DBRev 20.12.00.027 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • f6d2a50478 Bug 26498: DBRev 20.12.00.026 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 2 commits »

1 week ago

jonathan.druart pushed to master at Koha-community/Koha

  • 626d1f22a0 Bug 28013: (follow-up) Reset the patron loop To test: 1 - Apply all other patches and dependencies 2 - prove -v t/db_dependent/Circulation.t 3 - It fails 4 - Apply this patch 5 - It passes Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 850ad30393 Bug 28013: Unit tests Cover the case of multiple patrons and multiple items that can fill them Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • ded05deb10 Bug 28013: (follow-up) Correct and update call to CanItemBeReserved The current call checks for truth against a returned hash, we need to check the 'status' value Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 25d6024655 Bug 28013: (QA follow-up) Remove unused variable Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 0b8f4ec614 Bug 28013: Performance improvements to CanBookBeRenewed In the case of 'AllowRenewalIfOtherItemsAvailable' we check all existing reserves against all existing items. This patchset reduces the number of DB/subroutine calls To test: 1 - Apply patch 2 - prove -v t/db_dependent/Circulation.t Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 22 commits »

2 weeks ago

jonathan.druart pushed to master at Koha-community/Koha

  • b258a06844 Bug 28046: Add "Additional fields" link on acquisition navigation menu This patch adds a link to the "Additional fields" page in Administration to the sidebar menu shown on Acquisitions pages. To test, apply the patch and go to Acquisitions. - In the sidebar menu you should see a "Manage order basket fields" link. - The link should take you directly to the "Additional fields for 'aqbasket'" page. Signed-off-by: Séverine QUEUNE <severine.queune@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 9fae22c77e Bug 28006: Restore "Additional fields" on navigation menu This patch adds a link to the "Additional fields" page in Administration to the sidebar menu shown on Serials pages. To test, apply the patch and go to Serials. - In the sidebar menu you should see a "Manage subscription fields" link. - The link should take you directly to the "Additional fields for 'subscription'" page. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • f50897bd25 Bug 28066: (QA follow-up) Fix some single quote occurences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 5844622665 Bug 28066: Remove select tag's size attribute where it is 1 This patch removes the "size" attribute from <select> tags where the value of the attribute is 1. The attribute is unnecessary because the default value when the attribute is undefined is 1. This will allow for more careful sizing of <select> tags without a size attribute while preserving the desired behavior of <select> tags which have a size greater than 1. The patch modifies 83 files but makes the same minor corrections to each. I think examining the diff is sufficent, or testing a representative set of pages: - Administration -> MARC frameworks -> MARC structure -> Edit tag: The "Authorized value" select. - Patrons -> New patron: The "Library" select. - Reports -> Patrons with no checkouts: The "Into an application" selects. If anyone would like help testing any particular template I can follow-up. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 627897857c Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 58 commits »

2 weeks ago

jonathan.druart pushed to master at Koha-community/Koha

  • 02d82b142d Bug 27610: (follow-up) Hide <h1> on opac-main.tt This patch visually hides the <h1> on opac-main.tt so that libraries' customisations of their home pages are not disturbed by the introduction of a descriptive <h1>, but the heading is still available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Apply dependencies and all patches on this bug report 3) Ensure the <h1> "Koha home" heading on the OPAC main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 9db6630c61 Bug 27610: Changed pages of OPAC to have a <h1> Changed each of the pages in the OPAC to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in a follow up patch or bug. To test: 1) Go to the OPAC 2) Apply patch 3) Go to each of the pages and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored by: Catalyst IT Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • e49f4e6cea Bug 27610: Changed <h1> around logo to <div> To test: 1) Look at OPAC and the logo 2) Apply patch 3) Check Koha logo looks the same as before applying the patch 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • 4ca5eca203 Bug 27742: (follow-up) Add title for record blocked page This modifies the title for the template used when a bibliographic record is blocked. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • eecc4d3e8b Bug 27742: Page titles have unique info first Changed the titles of each page on the OPAC to display the unique information first, and the name of the website (e.g. Koha library catalog). This is fot accessibility reasons, such as when a screen reader user is going through tabs, they do not have to waste time listening to the website name, they can just find the unique page title first. To test: 1) Go to the OPAC 2) Apply patch 3) Go to each of the pages and check that the page title has the unique information about the page first, and the name of the website is at the end Sponsored by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
  • Compare 75 commits »

2 weeks ago

jonathan.druart pushed to master at Koha-community/Koha

  • 4e17726829 Bug 27835: DBRev 20.12.00.025
  • 126326b8b3 Bug 27816: "Click to edit" in Point of sale is untranslatable This patch adds an option to the Point of sale jEditable configuration to explicitly set the title attribute to "Click to edit." This will allow the string to be picked up for translation. To test, apply the patch and test that the correct string is translated. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR The "Click to edit" string should already have been translated, so it's not necessary to update the .po file. - Install the updated translation: > perl translate install fr-FR In the staff interface, switch to the language you're testing and open the point of sale page. Add some items for purchase. They should appear in the "This sale" table. Hover your mouse over the values in the "Coût" and "Quantité" columns. You should see the translated string, "Cliquer pour modifier." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
  • a6d77fb428 Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  • 1b32e66380 Bug 27933: Fix patron search result ordering On bug 27715 we restrict the order by dt params for security reasons. However in some cases the param passed is "columnname" instead of "table.columnname". We should make sure the table is part of the sort fieldname. Test plan: Do a "normal" patron search (from the patrons home page) and another patron search (guarantor for instance). Sort by cardnumber, date of birth, expiration date, asc, desc and confirm it works as expected. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
  • 675088752a Bug 27835: Turn off by default Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
  • Compare 9 commits »

1 month ago

jonathan.druart pushed to master at Koha-community/Koha

  • ec4bb0539a Bug 27969: Change wording on returns page To test: 1- go to /cgi-bin/koha/circ/returns.pl, click Checkin settings to show options 2- it says "Remember due date ..." 3- apply patch, reload 4- it says "Remember return date ..." Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

1 month ago