Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 15 Dec 2017 09:09:29 +0000 (10:09 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 22 Feb 2018 01:04:45 +0000 (01:04 +0000)
commit0442865a9e141b00031adde99526e756b9a6c3bf
treea72145d75b6a1b867f42a84907ac75fa2f9abb52
parent4b0e6261ac522939183b3dedc50910359bcc477f
Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest

[1] For consistency going back to IsItemOnHoldAndFound in this sub.
    This call is used in the on_shelf_holds == 2 case too.
    The routine will be refactored quite soon.
    Adding the else branch for on_shelf_holds == 0 for more clarity.
[2] Removing the test for found==F in reserves. In Koha F is only used
    when the hold is filled and moved to oldreserves.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Reserves.pm
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t