Search.pm minor cleanup
authorJoe Atzberger <joe.atzberger@liblime.com>
Wed, 8 Jul 2009 20:27:45 +0000 (15:27 -0500)
committerGalen Charlton <galen.charlton@liblime.com>
Thu, 30 Jul 2009 01:51:38 +0000 (21:51 -0400)
commit08c158319d7d1e5f4d74b7166831c64ab8e8b42f
tree494dd0b62dc1dd14898cde7bdfe0aeac96f862e0
parent11f05061ccbd6321285f27d0556c7986f2fa376c
Search.pm minor cleanup

Trying to move towards enabling warnings.
Add warn for unknown $query_type.
Use common $dbh.

push @array, ({key1=>value1...}); is the same as
push @array, {key1=>value1...};

if ( scalar(@$arrayref) > 0 ) is the same as
if (scalar @$arrayref)

Lines like:
    my @operators = @$operators if $operators;
are bad because we need @operators to be declared and in scope later,
even if it is undef.  Without $operators, the variable is not in scope.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
C4/Search.pm