Bug 22420: Remove wrong calculation on approved tags
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 27 Feb 2019 10:09:12 +0000 (07:09 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 7 May 2019 10:48:23 +0000 (10:48 +0000)
commit28bcc5aa68733e41d50a6a801088b06857968f42
treec7fe1b251088c11e7a7b80e88aca8ac174d4d14d
parent6a0246e24838cfba672baf4aef080588b7d091bf
Bug 22420: Remove wrong calculation on approved tags

Before the patch from bug 14385, the passed structure (that is returned
by get_approval_rows() looks like:

\ [
    [0] {
        approved           1,
        approved_by        51,
        approved_by_name   undef,
        date_approved      "2019-02-26 15:36:42",
        term               "another",
        weight_total       3
    },
    [1] {
    ...

After the introduced 'filtering', we loose the information about the
term weight!:

\ [
    [0] {
        approved               1,
        author                 "Heylin, Clinton.",
        biblionumber           1,
        borrowernumber         51,
        date_created           "2019-02-26 15:36:37",
        language               undef,
        subtitle               [],
        tag_id                 1,
        term                   "word",
        time_created_display   "15:36:37",
        title                  "E Street shuffle :",
        visible                1,
        XSLTBloc               "
            <<<BUNCH OF GENERATED HTML HERE>>>
    ...

The code even calls GetMarcBiblio. This needs to be reverted as it is
plain wrong. If it was worth removing *some* biblios from the
weight_total value, then this calculation should be done somewhere else,
without fetching the MARC data again.

Signed-off-by: Claudio <costalc@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
opac/opac-tags.pl