Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio
authorBenjamin Rokseth <benjamin.rokseth@deichman.no>
Thu, 15 Mar 2018 11:57:37 +0000 (12:57 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 4 Jun 2018 17:40:36 +0000 (13:40 -0400)
commit2c1f7d22810be37c4220566a675b3620d1ff4002
tree2f653b8f83819b8d22ae8d00369199adfd804cf6
parent4f0c8e3c88cb43f21f70e4d776442b489ee3f5dc
Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio

This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both slips
6) also note that there is no itemnumber or barcode in the requests from returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Reserves.pm
circ/hold-transfer-slip.pl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
t/db_dependent/Reserves/ReserveSlip.t [new file with mode: 0644]