Bug 14686: Add two granular permission for upload under tools
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 14 Mar 2016 12:42:10 +0000 (13:42 +0100)
committerBrendan Gallagher <bredan@bywatersolutions.com>
Wed, 27 Apr 2016 16:14:17 +0000 (16:14 +0000)
commit49a3b581b7d68251a0bf76aaf84b0565a6226fce
tree00ebd357e0fd1225d3748293593a706299e519de
parentb69402d14cd83ebedfd1272f9a42c4ceacfa60db
Bug 14686: Add two granular permission for upload under tools

[1] Upload_general_files
    This will allow you to access the tools/upload form via the Tools menu.
    And it will also allow you to add permanent uploads.

[2] Upload_manage
    It will allow you to delete uploads from other users.
    Note that anyone may delete his own uploads.
    It is not meant to include upload_general_files.

In order to not disturb existing users that now have edit_catalogue and are
using the plugin (read: added at least one record to uploaded_files), we
will add the first permission for them. New users will need to be authorized
in the usual way thereafter.

Note: If you only have one of the other permissions checked in allows_add_by,
e.g. stage_marc_import, you can add temporary uploads, but not permanent
uploads.

Test plan:
We are only testing the dbrev here, not if the perm works as advertised.
[1] Run the dbrev and check that you see the perms with a description on
    the Patron/Set permissions page.
[2] If you had records in uploaded_files and a user with edit_catalogue
    *only*, verify that this user now also has upload_general_files.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
installer/data/mysql/atomicupdate/14686_permissions.sql [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc