Bug 25046: Include borrowers.othernames in SELECT statement
authorAndreas Roussos <a.roussos@dataly.gr>
Thu, 2 Apr 2020 17:14:57 +0000 (19:14 +0200)
committerJoy Nelson <joy@bywatersolutions.com>
Fri, 1 May 2020 17:43:17 +0000 (17:43 +0000)
commit5b10df8bf77c8e7148caf042221d2ecd946742fa
tree07e864b9869faa16219a9eb059c6528b15651103
parentcf649efd7251243bc824bab542285ba17adafacb
Bug 25046: Include borrowers.othernames in SELECT statement

In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches
patron data from the database does not include borrowers.othernames
in the field list. As a consequence, when the output is in the form
of a DataTable, the Template Toolkit files that refer to .othernames
(such as the patron-title.inc include) won't display the information
from the 'Other name' input field if that field has been filled in.

This patch fixes that.

Test plan:
0) Have a few patrons with some data in the 'Other name' field.
1) Perform a generic search in Home > Patrons to ensure you will get
   a DataTable with results.
2) Observe that the 'Name' column does not include 'Other name' info.
3) Apply the patch, and restart Plack if necessary.
4) Repeat your search: this time you should see the information from
   the 'Other name' field, it will be next to the patron's First name
   and within parentheses.

Sponsored-by: Eugenides Foundation Library
Signed-off-by: Devinim <nazli@devinim.com.tr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/Utils/DataTables/Members.pm