Bug 9421: tools/picture-upload.pl not Plack-compatible
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Fri, 18 Jan 2013 02:39:38 +0000 (21:39 -0500)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 6 Feb 2013 17:35:46 +0000 (12:35 -0500)
commit75703cf6041aa83fe0decb0343856d745aa998d2
tree3b4972988a623aaa9379694702ad69cd8cd4dbf3
parentfe14e6ad40dec47573807b75a80e30228363f9ed
Bug 9421: tools/picture-upload.pl not Plack-compatible

This patch avoids using file-level private variables in subroutines
by passing the needed variables as parameters to the subroutines.

To test (under Plack):
1) Try uploading a patron image without applying the patch. Notice
   it fails.
2) Apply patch.
3) Try uploading a patron image again, noticing this time it succeeds.

To test (under Apache):
1) Apply patch.
2) Try uploading a patron image, confirm that it works.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Fixes Plack, does not break Apache. Works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
tools/picture-upload.pl