Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 3 May 2018 11:12:19 +0000 (13:12 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Jun 2018 13:37:15 +0000 (13:37 +0000)
commit8480491cce306272ff443408f5b92eac470a3d63
tree8fb9e5202bb0bc797b33dc27539ec8b1e1ea97d9
parentabc6422355c779440c61bcbc56f727b6848e3d02
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Triggered by the finding on bug 20697.
The three calls of GetHostItemsInfo should be controlled by the pref. This
patch makes the sub return an empty list when the pref is disabled.

The patch simplifies the sub by merging the two identical foreach loops
depending on the field number in MARC21/UNIMARC.

Will add a unit test on a follow-up patch.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Items.pm