Bug 19581: Remove 'split' option from Catmandu fixes for marc
authorNick Clemens <nick@bywatersolutions.com>
Sun, 5 Nov 2017 01:51:39 +0000 (01:51 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 14 May 2018 19:21:14 +0000 (19:21 +0000)
commit88e7fc2dab04f4a811e1f7f8333cf58bd7fd315a
tree2dcd309bba27b0531dc6dcfe9dbdfec42b1d3b9c
parent16c6ff1e3cb30f3aa4d2e23301b942eaf5a63d4c
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
    curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
    perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/SearchEngine/Elasticsearch.pm