Bug 12648: The users added to basket should have a permission
authorJonathan Druart <jonathan.druart@biblibre.com>
Fri, 29 Aug 2014 09:06:26 +0000 (11:06 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 11 Mar 2015 14:47:35 +0000 (11:47 -0300)
commit8e91a0f01df4a37b36dc3fe27bab3126a0dc8aa8
treea1549180bd9aa0051ac87f0ac9919491725928a4
parent753cbc4040344938ba937a9d24ce4b2869a9fecd
Bug 12648: The users added to basket should have a permission

Before this enh, the users to add to a basket should have the
acquisition.order_manage permission.
This patch reintroduces this behavior.

The code in acqui/add_user_search.pl was never used. The filter should
be done in the members/search service.

But it is not possible easily to filter using a sql query, so the filter
is done after. This means that we cannot use the DT pagination
(otherwise the results will become inconsistent).

Test plan:
1/ On adding patrons to a basket, verify that the search patron results contain
patron with the acquisition.order_manage permission.
2/ Verify that all patrons are return on the 'normal' patron search and
when adding patrons to an order.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Utils/DataTables/Members.pm
acqui/add_user_search.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/add_user_search.tt
svc/members/search