Bug 15810: Make sure the CGI->param is not called in a list context when creating...
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 12 Feb 2016 14:33:57 +0000 (14:33 +0000)
committerJulian Maurice <julian.maurice@biblibre.com>
Fri, 26 Feb 2016 09:58:39 +0000 (10:58 +0100)
commit8f637cc2ec1d31a2bdc9cd494e94bbd2a2dc381e
tree141b7e8374136ad1b4e9618fc72baf75f4457982
parent6dffa0cdc9a7d0946c29b30137b7397bbac5fa2d
Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves

This patch fixes the following bug:
If OpacAllowPublicListCreation is set to "not allow", the creation of a
private list raises an error at the OPAC.

CGI->param is called in a list context and some parameters are not
filled from the template if the pref is set to "not allow".
To make sure we don't have a "Odd number of elements in anonymous hash",
we force the context to scalar.

Test plan:
1/ Set OpacAllowPublicListCreation to "not allow"
2/ Create private and public lists at the OPAC and the intranet
=> Everything should work fine with this patch applied

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit d6329e4f96e46a5e2fbe0ced4d385c42d47e2a84)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
opac/opac-shelves.pl
virtualshelves/shelves.pl