Bug 17905: FIX CSRF in member-flags
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 13 Jan 2017 15:19:45 +0000 (16:19 +0100)
committerMason James <mtj@kohaaloha.com>
Mon, 30 Jan 2017 22:46:33 +0000 (11:46 +1300)
commit99a2c87fc1fe730a428fa5080ac0167656c718f5
tree422f323ed284f7afb12324b3dd837d2beccc602e
parentf68e2f242faaab5f01e1c215003f63b8a22168b6
Bug 17905: FIX CSRF in member-flags

If an attacker can get an authenticated Koha user to visit their page
with the url below, privilege escalation is possible

The exploit can be simulated triggering
    /cgi-bin/koha/members/member-flags.pl?member=42&newflags=1&flag=superlibrarian

Test plan:
Trigger the url above
=> Without this patch, 42 is now superlibrarian
=> With this patch, you will get the "Wrong CSRF token" error.

This vulnerability has been reported by MDSec.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0c3c162f767f5587f5fad7375151f8efca3689b3)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt
members/member-flags.pl