Bug 11342: fix error in OPAC self registration form if BorrowersTitles is empty
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 5 Dec 2013 14:13:35 +0000 (09:13 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 6 Jan 2014 15:26:02 +0000 (15:26 +0000)
commit9a5f737dcbb1c695130a3acafd46a63a44f2e4cf
treeadcc1cb2e1a2dddce25e34b04ed5944fb04441ad
parentb529ca00e0cac093fc32a1d123cdbcc84582c155
Bug 11342: fix error in OPAC self registration form if BorrowersTitles is empty

If BorrowersTitles is empty, it causes the library pulldown on the self
registration page to be empty, and to have the "Saluation" field have
the option "branches".

This patch also fixes a minor string capitalization issue.

Test Plan:
1) Enable OPAC self registration
2) Set the system preference BorrowersTitles to be empty
3) View the self registration page
4) Note the lack of branches in the home library pulldown
5) Apply this patch
6) Note the branches now display in the pulldown

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested in bootstrap and prog OPAC, with BorrowersTitle configured
and emptied.
Passes all tests and QA script.

Note: The titles pull down has 2 empty entries in master with
and without the patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt
opac/opac-memberentry.pl