Bug 15416: Warns on guided_reports.pl
authorAleisha <aleishaamohia@hotmail.com>
Mon, 18 Jan 2016 03:30:44 +0000 (03:30 +0000)
committerFrédéric Demians <f.demians@tamil.fr>
Tue, 1 Mar 2016 14:45:35 +0000 (15:45 +0100)
commitaa35dbb2fc2c9ccbe3c730e1a9ed2e00978eac42
tree5036bab7d48a8125edd727c16732980865ad1c9f
parent559a8dbb592a24b7d104ec01dae216774f68eb22
Bug 15416: Warns on guided_reports.pl

Initialising $phase variable to be '' if not defined.

To test:
1) Go to Reports -> Guided Reports Wizard
2) Notice warns
3) Apply patch
4) Refresh page
5) Confirm warns are gone and page still works as it should

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Warns are gone. Page still works as expected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch:
-my $phase = $input->param('phase');
-$phase //= '';
+my $phase = $input->param('phase') // '';

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 17c7c685f12dd09186d369f84cc725984328c5fa)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit fef0f0c367328b1f4ca22b9124783b12706d176e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
reports/guided_reports.pl