Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron
authorNick Clemens <nick@bywatersolutions.com>
Tue, 25 Feb 2020 14:42:29 +0000 (14:42 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Fri, 3 Apr 2020 21:12:13 +0000 (21:12 +0000)
commitabb8865d75df361de6cbbd812613d4761f837771
treeebae9ff384f1b210c239b125be61401601249a47
parent1f1ab3842371858ff5e76a721216a686684fd99d
Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron

The drop_hold routine was using the wrong parameter for item info in the patron's
array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable
holds

To test:
1 - Apply unit tests patch
2 - prove -v t/db_dependent/SIP/ILS.t
3 - It fails
4 - Apply second patch
5 - prove -v t/db_dependent/SIP/ILS.t
6 - It passes!

You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold
and check the messages, test coverage is improved by this patch and should be sufficient
for testing

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
C4/SIP/ILS/Patron.pm