Bug 22076: SIP checkin for withdrawn item returns ok in checkin response
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 7 Jan 2019 17:46:29 +0000 (12:46 -0500)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 28 Mar 2019 12:08:18 +0000 (12:08 +0000)
commitc7e48b0a1ad72b36445bc5d4202adb1b34bb8387
treec70760a35f9f9c89f49333236c7b8df6906c2bfe
parent7ac1457ffc27cf6ec5a3a7bab6abc8a010e02b6a
Bug 22076: SIP checkin for withdrawn item returns ok in checkin response

If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message.

To recreate:
 1 - Mark an item withdrawn
 2 - Set up sip server:
     https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
 3 - Set 'BlockReturnOfWithdrawnItems' to block
 4 - Use the sip_cli_emulator to checkin the withdrawn item
 5 - There is no error in the checkin

Test Plan:
1) Mark an item withdrawn
2) Set BlockReturnOfWithdrawnItems to block
3) Use the sip cli emulator to checkin the withdrawn item
4) Note the response begins with 101
5) Apply this patch
6) Restart all the things ( including SIP server )
7) Repeat checkin with sip cli emulator
8) Note the checkin now beings with 100

Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov>
Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction/Checkin.pm