projects / koha.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3c90043) | patch
BUG8446, Follow up: Refactor to clean up bad practice
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 31 Jul 2014 15:06:19 +0000 (15:06 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 16 Oct 2014 15:27:53 +0000 (12:27 -0300)
commitca86375872b1cc605918c33eb6c07ef85026ad4b
tree915be7b3296080c25419ddd3c2473b72a2e0a1aetree | snapshot
parent3c9004357d48944ce36d3964f7e6f1ba15702b71commit | diff
BUG8446, Follow up: Refactor to clean up bad practice

- A number of issues were highlighted whilst writing sensible unit tests
  for this module.
  - Removed unnessesary call to context->new();
  - Global variables are BAD!
  - Croaking is a wimps way out, we should handle errors early and
    properly.

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Auth.pm diff | blob | history
C4/Auth_with_shibboleth.pm diff | blob | history
Main Koha release repository