Bug 22778: Suggestions with no "suggester" can cause errors
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 25 Apr 2019 19:50:35 +0000 (15:50 -0400)
committerJoy Nelson <joy@bywatersolutions.com>
Mon, 4 May 2020 20:50:55 +0000 (20:50 +0000)
commitcac73b47ef221b32a6254fd25f22c86bcdd20c20
tree2e17f969a5d7707c8273085992ca77b10398b72c
parentef9f3adbddbffdf0f734e68e11a0c0424d6ec975
Bug 22778: Suggestions with no "suggester" can cause errors

If one tries to modify a suggestion that has no suggester you will get the following error:

Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506

Koha assumes that every suggestion has a borrowernumber in suggestedby

Test Plan:
1) Create a suggestion with an unpopulated suggestedby
2) Attempt to modify that suggestion
3) Note the error
4) Apply this patch
5) Restart all teh things
6) Attempt to modify that suggestion
7) No error!

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Suggestions.pm