Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions
authorOwen Leonard <oleonard@myacpl.org>
Tue, 4 Nov 2014 17:03:13 +0000 (12:03 -0500)
committerMason James <mtj@kohaaloha.com>
Tue, 20 Jan 2015 13:44:34 +0000 (02:44 +1300)
commitcb7e1c6066ff59ba436052f2eb944c826d6e9ea0
tree1efad83392cd57e5e33d08b177e6107dffb7a81c
parent2a1ba095cb6c460941569c26ddb225964fb90606
Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions

This patch modifies the way the checkouts script sets the "Always show
checkouts" cookie so that it is set with an explicit expiration date
(+365 days). This will allow the cookie to persist across browser
sesssions.

To test, apply the patch and clear your browser cookies to start with a
clean slate.

- Check out to a patron who has existing checkouts. Their checkouts
  should not load by default.
- Check the "Always show checkouts immediately" checkbox.
- Close your browser.
- Reopen your browser and check out to that patron again. Checkouts
  should now be displayed by default.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Works as described. I confirm that without this patch, the un-persistance of
"show checkouts" choice is very perturbing for librarians coming from previous
version of Koha.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, no problems found.
Signed-off-by: Mason James <mtj@kohaaloha.com>
koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js