Bug 18200: Fix a potential issue with preceding space in GetMarcUrls
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 2 Mar 2017 13:24:17 +0000 (14:24 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 31 Mar 2017 14:15:54 +0000 (14:15 +0000)
commitd455dc31d4f423a154009823b0b8db925c5efe48
tree5f25177b74a820a9715fd06d4bd403da59928a4f
parentcd812cb42136fb0dda895f0af69f8abd4fe07ac0
Bug 18200: Fix a potential issue with preceding space in GetMarcUrls

Trims the URL in order prevent prefixing a space with http://
Normally you won't have a preceding space here, but I saw it happening
one day and it does not cost much to resolve it.

Bonus: Adding few simple tests in t/db_dependent/Biblio.t.

Test plan:
[1] Run t/db_dependent/Biblio.t
[2] Add a 856$u with preceding space (MARC21)
[3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Followed test plan, works as expected
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Biblio.pm
t/db_dependent/Biblio.t