Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 3 May 2018 11:12:19 +0000 (13:12 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 28 Jun 2018 08:21:05 +0000 (10:21 +0200)
commitd62c83a2416e603e2d2508aa58aa6efb72964024
treefa0bfe6c640fb269ffa1d7977b10e2307fec1745
parent0c09588514f49b7d02bb9adecb4d6cb9cc35b74d
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Triggered by the finding on bug 20697.
The three calls of GetHostItemsInfo should be controlled by the pref. This
patch makes the sub return an empty list when the pref is disabled.

The patch simplifies the sub by merging the two identical foreach loops
depending on the field number in MARC21/UNIMARC.

Will add a unit test on a follow-up patch.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 7861cc07ba8afdf09079c7b51fdb99ad99132688)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Items.pm