Bug 19496: Fixing to_address for patron notes
authorAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 27 Nov 2017 21:33:58 +0000 (21:33 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 14 Dec 2017 13:52:20 +0000 (13:52 +0000)
commitde3b3115b610d43bf320aa0bfb9902c9d417ea2d
tree6c0784902c83fde9da1252328c4f2e8729b6d513
parent7e691bc6d8695377e12896be085039c81115e4d0
Bug 19496: Fixing to_address for patron notes

This patch ensures the patron note to_address is the branch email or the
Koha Admin email, and the from_address is the patron's email.

To test:
1) Ensure syspref 'allowcheckoutnotes' is turned on
2) Go to OPAC, leave a note on a checkout
3) Confirm that the note is received (in mysql message_queue) but the
to_address is the patron's email - this is wrong
4) Apply patch and refresh OPAC
5) Leave a note on a checkout
6) Confirm that the note is received in message queue
7) Confirm that the to_address is one of:
- branch email
- branch reply to
- syspref ReplytoDefault
- syspref KohaAdminEmailAddress
8) Confirm that the from_address is one of:
- patron email
- patron emailpro
- patron B_email

Sponsored-by: Catalyst IT
Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
opac/opac-issue-note.pl
opac/svc/patron_notes