Bug 17990: Refactor Perl module versions check
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 25 Jan 2017 10:33:43 +0000 (11:33 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 17 Feb 2017 12:13:44 +0000 (12:13 +0000)
commit2b9662e0ca87f6344a8edb9093e06c811295df6c
tree8800314eb3f0ed96221e966faaad6233c7cf4730
parent87dacffdf3e3a2371720269af22a5de90d3f90fc
Bug 17990: Refactor Perl module versions check

The code is duplicated, variable are not set ($_), code is hard to read,
not covered by tests and the subroutine has 2 completely different
behaviors depending on the presence of the "module" parameter.
No need more ti rewrite it.

Test plan:
- Use koha_perl_deps.pl with the different options (-u -m -a -i)
- Go on the about page, "Perl modules" tab

You should not see any differences from before and after this patch

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Installer/PerlModules.pm
about.pl
installer/install.pl
koha_perl_deps.pl
t/Installer_PerlModules.t
t/Installer_pm.t