Bug 7567: convert news add/update routines to take hashref; fix bugs
authorMark Tompsett <mtompset@hotmail.com>
Mon, 16 Dec 2013 05:41:47 +0000 (00:41 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 7 Apr 2014 18:13:56 +0000 (18:13 +0000)
commit2f2a0cf53e64a02f65cc0797bdcf6c0fd9a8dc2a
tree1cec422c1c84daedd276686e5683f4ca93e66448
parentd3eaa627176d3945888da33082bfb12e05e5ee25
Bug 7567: convert news add/update routines to take hashref; fix bugs

Changed the add and update functions to use a hash reference
for the parameter, so that adding or subtracting parameters
should be easier. Added some POD for the add_opac_news and
upd_opac_news functions, so that developers would know how to
call it.

The hashref changes resulted in being able to return 0 for
failure and 1 for success. This meant adding a couple tests
to the test file.

And while testing, there was some sort of logic problem with
the matter of '' being all, but selecting all only showed
things set for all, and excluded particular languages, or other
interfaces.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/NewsChannels.pm
t/db_dependent/NewsChannels.t [changed mode: 0755->0644]
tools/koha-news.pl