Bug 25236: Fix semantic heading for opac-facets.inc
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 Jun 2020 10:37:26 +0000 (11:37 +0100)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 13 Jul 2020 03:08:27 +0000 (15:08 +1200)
commit3bb05edced373175227d4c2fb704db75519ae78c
tree50bf3edd9f85d2a70e3db9f6297a1c88f9f481a9
parent7519f4d065d258653a08cf46a8b142e702ca5af0
Bug 25236: Fix semantic heading for opac-facets.inc

Prior to this patch, the opac-facets side navigation box contained
semantically incorrect headings.

Test plan
1/ Perform a search which yields some results in the OPAC
2/ Inspect the 'Refine your search' elements on the left side of the
screen. Note that the headings are H1 (Koha page title) > H4 (Refine
your search) > H5 (Headings within 'Refine your search' box)
3/ Apply this patch and follow
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
4/ Reload the page (Flushing the cache to ensure the CSS change load)
5/ Re-inspect the 'Refine your search' elements and note the heading
semantics are now H1 (Title of page) > H2 (Refine your search) > H3
(Headings within 'Refine your search')
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f88d56f689e514b47930d617049358fdf9b68608)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit cc75932f3eca746e8e2c08125306a94952b8a87d)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc