bug 10559: remove spurious "statement handle still active" warnings
authorGalen Charlton <gmc@esilibrary.com>
Tue, 9 Jul 2013 17:53:16 +0000 (17:53 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 14 Aug 2013 14:01:37 +0000 (11:01 -0300)
commit5e7452758949e037fcf286cead721b559dd7d0e3
tree25cd51a4222629b70ebd251f1dc4677bbb0e237d
parent3db6e17c9eb05e3680328a76b352aa9cf555db43
bug 10559: remove spurious "statement handle still active" warnings

Generating (e.g.) overdue notices can result in spurious warnings in
the cronjob logs:

$ ./misc/cronjobs/overdue_notices.pl -t -library CPL
prepare_cached(SELECT * FROM issues WHERE     itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589

This patch removes the warning by making sure that the relevant statement
handle is finished after fetching its first row of results.

To test:

[1] Set up an overdue loan such that running overdue_notices.pl will
    trigger the generation of a notice.
[2] Run overdue_notices.pl -t and note the warning message.
[3] Apply the patch.
[4] Run overdue_notices.pl -t again and note that the warning message
    is no longer displayed.
[5] Check the message_queue table and verify that the overdue
    notices generated in steps 2 and 4 have the same text.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 2bab95cac5f43b034adec36ec62a8c8f7f520627)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Letters.pm