Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN...
authorNick Clemens <nick@bywatersolutions.com>
Wed, 30 Dec 2015 23:14:37 +0000 (23:14 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Oct 2016 11:58:14 +0000 (11:58 +0000)
commit68ced964fd254e7cba67a9b1b867907c557888c4
treef7b7e16c553bd9fefbdf3e48312c9c7ebe87286b
parent6b8f703364c8dcd9a263e9f77596ca0fba1a1bc4
Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher

This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match
of ISSNs with or without hyphens. It uses Business::ISSN in order to
follow the use of Business::ISBN and allow for validation of ISSNs

To test:
1 - Find a record in your system with an ISSN (or add one)
2 - Stage a record containing the same ISSN but lacking a hyphen
3 - Matching on ISSN should find 0 matches
4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import
5 - Matching should find 0
6 - Apply patch
7 - Update datbase and install Business::ISSN
8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no
change
9 - Set AggressiveMatchOnISSN as do and repeat original test
10 - You should find a match
11 - prove t/Koha.t - all tests pass

Sponsored by North Central Regional Library System (NCRL) www.ncrl.org

Signed-off-by: Chad Roseburg <croseburg@ncrl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Installer/PerlDependencies.pm
C4/Koha.pm
C4/Matcher.pm
installer/data/mysql/atomicupdate/bug_14629-add_AgressiveMatchOnISSN_syspref.sql [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
t/Koha.t