Bug 14937: Expiration date for holds based onReservesMaxPickUpDelay should not requir...
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 1 Oct 2015 16:59:26 +0000 (12:59 -0400)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 19 Oct 2015 14:59:21 +0000 (11:59 -0300)
commitc6d0202569146f52898363eda621f771b61cc918
treeafc053c36784915d11e6d132d05fa1b62eb61a3e
parent5a9b8d9359424a3f0316f89348038fbb290e722b
Bug 14937: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

C4::Letters::_parseletter will replace reserves.expirationdate with the
date a hold will be marked as problematic ( holds over ) if both
ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled.
There is no reason this feature needs to rely on
ExpireReservesMaxPickUpDelay as there are many libraries that would like
to send the last day to pick up a hold in notices, but would rather deal
with the expired waiting holds manually rather than have Koha cancel
them automatically.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Disable ExpireReservesMaxPickUpDelay
4) Add reserves.expirationdate to your HOLD notice
5) Fill a hold for a patron
6) View the message, not that reserves.expirationdate is replaced
   with the date the hold will be marked as problematic

Signed-off-by: Karl Holton <kholten@switchinc.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Letters.pm