Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 30 May 2019 14:36:31 +0000 (09:36 -0500)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 11 Jun 2019 13:51:05 +0000 (15:51 +0200)
commite69744172a33165758562c6c786a1135361c7509
tree167ef8eec30ba215ee5e82efde403e687795d7eb
parent203ae6e8ecf2606922490fe0433e5eccfc8d95c5
Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes

If strict SQL modes are set, the insert of authorities_normal_marc21.sql
will fail.

Test plan:
DELETE FROM auth_subfield_structure;
DELETE FROM auth_tag_structure;
DELETE FROM auth_types;
SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION';
source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql

You should not see any errors.
Without this patch you see:
ERROR 1366 (22007) at line 280 in file:
'/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql':
Incorrect integer value: ' for column 'linkid' at row 148
'

Signed-off-by: nabila <lovenabila@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 703ec1e2f24345146c997398b9c0cc492016455d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql