koha.git
22 months agoBug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits
Tomas Cohen Arazi [Tue, 10 Jul 2018 17:53:47 +0000 (14:53 -0300)]
Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21267: Set X-FORWARDED-PROTO https if required
Tomas Cohen Arazi [Fri, 24 Aug 2018 13:45:52 +0000 (10:45 -0300)]
Bug 21267: Set X-FORWARDED-PROTO https if required

This patch makes the apache configuration for the reverse proxy
(required for Plack) so it sets the X-FORWARDED-PROTO header correctly
for Plack::Middleware::ReverseProxy to use it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Since we actually resolve 19799 now (Changing language on OPAC redirects
back to homepage), I will move that code to a new enh report.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 17084: Automatic debian/control updates (unstable/master)
Nightly Build Bot [Thu, 30 Aug 2018 22:25:45 +0000 (00:25 +0200)]
Bug 17084: Automatic debian/control updates (unstable/master)

This is a result of Bug 21068: Remove NorwegianPatronDB related code

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: DBRev 18.06.00.023
Nick Clemens [Fri, 31 Aug 2018 11:58:49 +0000 (11:58 +0000)]
Bug 18639: DBRev 18.06.00.023

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: (QA follow-up) Fix formatting of replacement cost when modifying an order
Katrin Fischer [Tue, 28 Aug 2018 07:55:37 +0000 (07:55 +0000)]
Bug 18639: (QA follow-up) Fix formatting of replacement cost when modifying an order

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: Alter DB update to populate replacementprice from rpp initially
Nick Clemens [Mon, 27 Aug 2018 18:21:23 +0000 (18:21 +0000)]
Bug 18639: Alter DB update to populate replacementprice from rpp initially

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: (follow-up) Populate replacement price from list price during ordering
Nick Clemens [Mon, 27 Aug 2018 13:33:50 +0000 (13:33 +0000)]
Bug 18639: (follow-up) Populate replacement price from list price during ordering

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: Use replacementprice when creating order from quote
Colin Campbell [Mon, 11 Jun 2018 10:44:39 +0000 (11:44 +0100)]
Bug 18639: Use replacementprice when creating order from quote

Updates column name from rrp -> replacementprice when creating
order from EDI QUOTE message
Also ensure other rrp_tax* fields populated

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: Unit tests
Nick Clemens [Fri, 29 Dec 2017 16:22:08 +0000 (16:22 +0000)]
Bug 18639: Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: Add replacementprice field to acquisitions workflow
Nick Clemens [Fri, 29 Dec 2017 16:16:23 +0000 (16:16 +0000)]
Bug 18639: Add replacementprice field to acquisitions workflow

To test:
 0 - Apply patches and updatedatabase
 1 - Add an order to a basket
 2 - You should note new 'Retail price field'
 3 - You should have a separate 'Replacement price' field
 4 - Enter values and ensure they are saved as expected
 5 - In the basket you should see the replacement price
 6 - Modify order and ensure value is loaded and saved correctly
 7 - Add and cancle an order and esure replacement price shows/saves
 8 - Close basket
 9 - Receive an order
10 - You should be able to edit replacement price
11 - 'retail price' field is not editable
12 - Check associated item, replacement price in item should be updated
13 - Cancel receipt, check item. receive again with new replacement
price, check item
14 - Price should be correctly updated
15 - Finish receipt, value should show in table
16 - Test with receive from file

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 18639: Add replacementprice field to aqorders
Nick Clemens [Fri, 29 Dec 2017 16:14:07 +0000 (16:14 +0000)]
Bug 18639: Add replacementprice field to aqorders

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: (follow-up) Remove traces in C4::Search and C4::Context
Tomas Cohen Arazi [Fri, 24 Aug 2018 18:45:16 +0000 (15:45 -0300)]
Bug 14302: (follow-up) Remove traces in C4::Search and C4::Context

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: (follow-up) Remove traces in koha-create
Tomas Cohen Arazi [Fri, 24 Aug 2018 18:15:30 +0000 (15:15 -0300)]
Bug 14302: (follow-up) Remove traces in koha-create

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: (QA follow-up) Remove remaining file
Tomas Cohen Arazi [Fri, 24 Aug 2018 17:55:07 +0000 (14:55 -0300)]
Bug 14302: (QA follow-up) Remove remaining file

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: Remove grs1 records from test data
Jonathan Druart [Mon, 20 Feb 2017 16:02:19 +0000 (16:02 +0000)]
Bug 14302: Remove grs1 records from test data

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: Remove GRS1 specific code
Jonathan Druart [Mon, 20 Feb 2017 15:54:59 +0000 (15:54 +0000)]
Bug 14302: Remove GRS1 specific code

Remove:
- BIB_INDEX_MODE and AUTH_INDEX_MODE env var
- bib_index_mode and auth_index_mode options from scripts
- Warnings from about page, just kept one if zebra_bib_index_mode or
zebra_auth_index_mode still exist in config and are set to grs1

Test plan:
- Install Koha from src
- Install Koha from pkg
- Read the code, carefully!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Rebased

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 14302: Remove GRS1 related files
Jonathan Druart [Mon, 20 Feb 2017 15:54:34 +0000 (16:54 +0100)]
Bug 14302: Remove GRS1 related files

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20690: Update two-column templates with Bootstrap grid: Acquisitions part 4
Owen Leonard [Tue, 1 May 2018 15:49:26 +0000 (15:49 +0000)]
Bug 20690: Update two-column templates with Bootstrap grid: Acquisitions part 4

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

- Acquisitions home page -> Click a "spent" value for a fund.
- Acquisitions -> Vendor -> Vendor details.
- Acquisitions -> Vendor -> Uncertain prices
- Acquisitions -> Vendor -> Receive shipments
  - Click an "Invoice number" link in the table of shipments.
    - Click "Receive" for one of the titles in pending orders.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20672: Update two-column templates with Bootstrap grid: Acquisitions part 3
Owen Leonard [Tue, 1 May 2018 15:47:24 +0000 (15:47 +0000)]
Bug 20672: Update two-column templates with Bootstrap grid: Acquisitions part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

- Acquisitions -> Vendor -> Add to basket -> From an existing record ->
  Search results.
  - Order
- Acquisitions -> Vendor -> Add to basket -> From a subscription
- Acquisitions -> Vendor -> Add to basket -> From a suggestion
- Acquisitions -> Vendor -> Add to basket -> From an external source
  - Search for an title which already exists in your catalog
  - Select a search result which has an ISBN matching the title in your
    catalog.
  - Order. The duplicate warning page is the one modified.
- Acquisitions home page -> Click an "Ordered" value for a fund.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21201: Remove GetItemnumbersForBiblio
Jonathan Druart [Mon, 6 Aug 2018 19:40:59 +0000 (16:40 -0300)]
Bug 21201: Remove GetItemnumbersForBiblio

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21201: Replace C4::Items::GetItemnumbersForBiblio calls
Jonathan Druart [Mon, 6 Aug 2018 19:40:44 +0000 (16:40 -0300)]
Bug 21201: Replace C4::Items::GetItemnumbersForBiblio calls

Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with
    my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber")

Test plan:
- Use the GetAvailability service of ILS-DI
- Try to place a hold on an item that is available and another one
- Use the batch record deletion tool to remove record with and without items.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP
Josef Moravec [Fri, 17 Aug 2018 05:26:57 +0000 (05:26 +0000)]
Bug 21184: (follow-up) Fix adding barcode to waiting hold item in SIP

Test plan:
1) Set up your SIP: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
2) Run:
misc/sip_cli_emulator.pl -a localhost -p 6001 -su <login> -sp <passsword> -l <library_code> --patron <borrowernumber> -s "Y         " -m patron_information

the -s parameter says what kind of additional information you want to see

3) Check the response: if the requested patron has waiting hold, there
is field "AS" with the barcode of waiting item

The right response looks like this:
64              00120180817
052434000100000000000000000000AOCPL|AA1|AEKoha Admin|BLY|CC5|AS39999000004410|PCS|PIY|AFGreetings from Koha. |

More reading ;)
http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21184: Remove GetBarcodeFromItemnumber
Jonathan Druart [Mon, 6 Aug 2018 18:59:52 +0000 (15:59 -0300)]
Bug 21184: Remove GetBarcodeFromItemnumber

Test plan:
  git grep GetBarcodeFromItemnumber
should not return anything

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls
Jonathan Druart [Mon, 6 Aug 2018 18:59:38 +0000 (15:59 -0300)]
Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls

Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with
    my $barcode = Koha::Items->find($itemnumber)->barcode;
But if we are not sure that the item exists, we should test the return
of ->find before ->barcode

Test plan:
- Edit an item
- Check an item in

- Test SIP - I do not really know how to trigger that code, apparently
misc/sip_cli_emulator.pl does not deal with holds. Any ideas?

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls
Jonathan Druart [Mon, 6 Aug 2018 20:56:38 +0000 (17:56 -0300)]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19383: DBRev 18.06.00.022
Nick Clemens [Thu, 30 Aug 2018 20:13:37 +0000 (20:13 +0000)]
Bug 19383: DBRev 18.06.00.022

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19383: (QA follow-up) Remove unused name variable
Katrin Fischer [Wed, 22 Aug 2018 18:49:52 +0000 (20:49 +0200)]
Bug 19383: (QA follow-up) Remove unused name variable

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19383: Add ability to print hold receipts automatically
Kyle M Hall [Thu, 3 May 2018 12:23:13 +0000 (08:23 -0400)]
Bug 19383: Add ability to print hold receipts automatically

Some libraries don't wish to require librarians to confirm each hold during checkin. Instead they would like to only be alerted that a hold was filled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref HoldsAutoFill
4) Check in an item that should be trapped for a hold
5) Note that instead of the modal asking if the hold should be filled,
   instead you get a message box showing the hold was filled, along
   with a button to print the hold slip.
6) Enable the new syspref HoldsAutoFillPrintSlip
7) Repeat step 4
8) Note the same behavior, but this time the print dialog displays
   automatically

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21068: (RM follow-up) Schema updates
Nick Clemens [Thu, 30 Aug 2018 16:10:09 +0000 (16:10 +0000)]
Bug 21068: (RM follow-up) Schema updates

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20366: (RM follow-up) Fix typo 'hrml'
Nick Clemens [Thu, 30 Aug 2018 13:40:18 +0000 (13:40 +0000)]
Bug 20366: (RM follow-up) Fix typo 'hrml'

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20366: (follow-up) Fix link to subscription
Josef Moravec [Thu, 2 Aug 2018 13:15:16 +0000 (13:15 +0000)]
Bug 20366: (follow-up) Fix link to subscription

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20366: Add subscription info to the acq tab on the biblio detail page
Jonathan Druart [Tue, 8 May 2018 16:31:55 +0000 (13:31 -0300)]
Bug 20366: Add subscription info to the acq tab on the biblio detail page

On the "Acquisition details" tab of the bibliographic detail page, the
subscription information are missing.
This patch replace the call to GetHistory with Koha::Acquisition::Orders
in order to simplify the code and make use of new Koha::
packages/methods.

TODO: Add column settings (show/hide columns) to this table (?)

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20366: Add new method Koha::Acquisition::Basket->basket_group
Jonathan Druart [Tue, 8 May 2018 16:32:47 +0000 (13:32 -0300)]
Bug 20366: Add new method Koha::Acquisition::Basket->basket_group

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20366: Add new method Koha::Acquisition::Order->subscription
Jonathan Druart [Tue, 8 May 2018 16:30:44 +0000 (13:30 -0300)]
Bug 20366: Add new method Koha::Acquisition::Order->subscription

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20365: Allow several orders on the same subscriptions
Jonathan Druart [Wed, 28 Mar 2018 15:53:42 +0000 (12:53 -0300)]
Bug 20365: Allow several orders on the same subscriptions

Do we really need this limitation?

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: (RM follow-up) Add missing filters
Nick Clemens [Thu, 30 Aug 2018 13:46:06 +0000 (13:46 +0000)]
Bug 20726: (RM follow-up) Add missing filters

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add title to the price column headers
Jonathan Druart [Mon, 4 Jun 2018 20:11:46 +0000 (17:11 -0300)]
Bug 20726: Add title to the price column headers

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Sort by statuses then ordernumbers
Jonathan Druart [Tue, 29 May 2018 20:10:58 +0000 (17:10 -0300)]
Bug 20726: Sort by statuses then ordernumbers

Not received and most recent at the top.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add show/hide already received orders links
Jonathan Druart [Tue, 29 May 2018 19:59:05 +0000 (16:59 -0300)]
Bug 20726: Add show/hide already received orders links

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add DataTables
Jonathan Druart [Mon, 7 May 2018 23:07:28 +0000 (20:07 -0300)]
Bug 20726: Add DataTables

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add acquisition history on the subscription detail page
Jonathan Druart [Mon, 7 May 2018 23:00:25 +0000 (20:00 -0300)]
Bug 20726: Add acquisition history on the subscription detail page

Since bug 20365 is going to add the ability to create several pending orders on
the same subscription we should display the history of the acquisitions on the
subscription detail page.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add new method Acquisition::Order->invoice
Jonathan Druart [Mon, 7 May 2018 22:46:05 +0000 (19:46 -0300)]
Bug 20726: Add new method Acquisition::Order->invoice

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20726: Add new method Koha::Acquisition::Order->fund
Jonathan Druart [Mon, 7 May 2018 22:29:19 +0000 (19:29 -0300)]
Bug 20726: Add new method Koha::Acquisition::Order->fund

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21207: Remove unused RM C4::Overdues::GetItems sub
Jonathan Druart [Mon, 6 Aug 2018 22:42:20 +0000 (19:42 -0300)]
Bug 21207: Remove unused RM C4::Overdues::GetItems sub

Test plan:
  git grep GetItems
  | grep -v GetItemsInCollection
  | grep -v GetItemsForInventory
  | grep -v GetItemsInfo
  | grep -v GetItemsLocationInfo
  | grep -v GetItemsAvailable
  | grep -v GetItemsByBiblioitemnumber

should not return any occurrences of code in perl scripts

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21157: Compiled CSS
Nick Clemens [Thu, 30 Aug 2018 13:21:35 +0000 (13:21 +0000)]
Bug 21157: Compiled CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21157: Improve style of OPAC login modal
Owen Leonard [Mon, 13 Aug 2018 14:07:46 +0000 (14:07 +0000)]
Bug 21157: Improve style of OPAC login modal

This patch revises the style of the OPAC's login form modal view. The
goal is simply to make it look nicer.

To test, apply the patch and regenerate the OPAC's CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

In the OPAC, click the "Log in to your account" link at the top of the
page. It should trigger the login modal. While the modal is displayed,
resize the browser width to confirm that the form handles different
widths well.

Sign off if you think this is an improvement.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 13618: (follow-up) Add html filters to all the variables
Jonathan Druart [Wed, 29 Aug 2018 17:38:56 +0000 (14:38 -0300)]
Bug 13618: (follow-up) Add html filters to all the variables

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21139: (follow-up) Floating toolbars - Remove unecessary height
Jonathan Druart [Wed, 15 Aug 2018 17:21:47 +0000 (14:21 -0300)]
Bug 21139: (follow-up) Floating toolbars - Remove unecessary height

Found where QAing bug 20935, we actually want the hidden toolbar to be
the exact same height as the visible one.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21183: Fix ->get_column call context
Jonathan Druart [Thu, 16 Aug 2018 15:12:11 +0000 (12:12 -0300)]
Bug 21183: Fix ->get_column call context

I am not sure to understand what's going on here.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
Jonathan Druart [Mon, 6 Aug 2018 18:53:33 +0000 (15:53 -0300)]
Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls

C4::Items::GetItemnumberFromBarcode calls can be replaced with
  Koha::Items->find({ barcode => $barcode });

We should make sure the barcode existed in DB and so that ->find
returns an object. Note that most of the time we just wanted to know if
the barcode existed.
The changes are very simple, the only one that need attention is
the one in batchMod.pl. It is basically reusing what we did on
bug 21141.

Test plan:
Use the batch item modification/deletion tools to modify/delete items
from their barcode (using the textarea or a file)

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21183: Remove GetItemnumberFromBarcode
Jonathan Druart [Mon, 6 Aug 2018 18:53:54 +0000 (15:53 -0300)]
Bug 21183: Remove GetItemnumberFromBarcode

Test plan:
  git grep GetItemnumberFromBarcode
should not return anything

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20740: Update two-column templates with Bootstrap grid, Administration part 4
Owen Leonard [Fri, 4 May 2018 15:18:59 +0000 (15:18 +0000)]
Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Currencies and exchange rates
   - View and edit currencies
 - Administration -> Did you mean?
 - Administration -> EDI accounts
   - View and edit accounts
 - Administration -> Library EANs
   - View and edit EANs
 - Administration -> Item search fields
   - View and edit item search fields

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20739: Update two-column templates with Bootstrap grid, Administration part 3
Owen Leonard [Tue, 1 May 2018 18:46:33 +0000 (18:46 +0000)]
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Columns settings
 - Administration -> Patron categories
   - View and edit patron categories
 - Administration -> Cities and towns
   - View and edit cities
 - Administration -> Classification sources
   - View and edit classification sources
 - Administration -> MARC bibliographic framework test

I'm not sure if this standalone interface is actually in use, but you
can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a
form which is usually submitted from the circulation and fines rules
interface. View the page to confirm it looks correct.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20738: Update two-column templates with Bootstrap grid, Administration part 2
Owen Leonard [Tue, 1 May 2018 18:31:00 +0000 (18:31 +0000)]
Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Authority types
   - View list of and edit authority types
     -> MARC tag structure for an authority type
        - View list of and edit tags
          -> Subfields
             - View list of and edit subfields
 - Administration -> MARC bibliographic framework
   - View list of and edit frameworks
 - Administration -> Libraries
   - View and edit libraries
 - Administration -> Library transfer limits

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20736: Update two-column templates with Bootstrap grid, Administration part 1
Owen Leonard [Tue, 1 May 2018 17:39:51 +0000 (17:39 +0000)]
Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Budgets
   - View budgets list, view and edit budgets
   - View budget -> Planning -> Plan by months
 - Administration -> Funds
   - View funds list, view and edit funds
 - Acquisitions -> Vendor -> Contracts
   - View contracts list, view and edit contracts
 - Administration -> Audio alerts
 - Administration -> Authorized values

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19991: Remove warning from opac-user
Jonathan Druart [Wed, 15 Aug 2018 18:17:57 +0000 (15:17 -0300)]
Bug 19991: Remove warning from opac-user

Use of uninitialized value in split at
/home/vagrant/kohaclone/opac/opac-user.pl line 78.

Use of uninitialized value $search_query in string ne at
/home/vagrant/kohaclone/opac/opac-user.pl line 367.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19991: use Modern::Perl in OPAC perl scripts
Charlotte Cordwell [Wed, 17 Jan 2018 20:46:59 +0000 (20:46 +0000)]
Bug 19991: use Modern::Perl in OPAC perl scripts

Test Case:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

errors/400.pl
errors/401.pl
errors/402.pl
errors/403.pl
errors/404.pl
errors/500.pl
opac-account-pay-paypal-return.pl
opac-alert-subscribe.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl
opac-browser.pl
opac-ics.pl
opac-image.pl
opac-imageviewer.pl
opac-messaging.pl
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl
opac-overdrive-search.pl
opac-passwd.pl
opac-patron-image.pl
opac-privacy.pl
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl
opac-renew.pl
opac-sendshelf.pl
opac-serial-issues.pl
opac-showreviews.pl
opac-suggestions.pl
opac-tags_subject.pl
opac-topissues.pl
opac-user.pl
sco/help.pl
sco/printslip.pl
sco/sco-patron-image.pl
svc/overdrive_proxy
svc/suggestion
unapi

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21096: Do not display loggedinusername in template
Jonathan Druart [Wed, 25 Jul 2018 15:25:58 +0000 (12:25 -0300)]
Bug 21096: Do not display loggedinusername in template

This patch is a little fix for a much bigger hidden issues.

The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")

What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834             $s_userid = $session->param('id') // ''

The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?

Test plan:
Make sure the original issue is fixed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21168: Handle deleted checked-in items on checking in
Jonathan Druart [Fri, 10 Aug 2018 20:02:38 +0000 (17:02 -0300)]
Bug 21168: Handle deleted checked-in items on checking in

circ/returns.pl generates a server error when attempting to checkin an item while
the list of previously-returned items contains an item that has been deleted.
Error text: Can't call method "biblio" on an undefined value at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606.

Test plan:
- checkout two items
- checkin item1
- on a separate tab, delete item1
- on the original tab (which still shows item1 in the list of Checked-In Items), attempt to check in item2
=> No error appears

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21231: BlockReturnofLostItems does not prevent lost items being found
Kyle M Hall [Thu, 16 Aug 2018 11:11:17 +0000 (07:11 -0400)]
Bug 21231: BlockReturnofLostItems does not prevent lost items being found

When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can then be checked in a second time and returned as it is no longer lost.

Test Plan:
1) Set an item to lost
2) Set BlockReturnOfLostItems to Block
3) Check the lost item in
4) Checkin  message should say item is lost and cannot be returned
5) Check lost status of item, it should remain unchanged

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21231: Add Unit Test
Kyle M Hall [Thu, 16 Aug 2018 11:10:43 +0000 (07:10 -0400)]
Bug 21231: Add Unit Test

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21068: DBRev 18.06.00.021
Nick Clemens [Thu, 30 Aug 2018 10:59:58 +0000 (10:59 +0000)]
Bug 21068: DBRev 18.06.00.021

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21068: Remove table borrower_sync if needed
Jonathan Druart [Fri, 24 Aug 2018 20:00:31 +0000 (17:00 -0300)]
Bug 21068: Remove table borrower_sync if needed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21068: DB changes
Jonathan Druart [Wed, 15 Aug 2018 15:49:02 +0000 (12:49 -0300)]
Bug 21068: DB changes

The update DB entry will not remove the prefs if NorwegianPatronDBEnable
is set.
This patch could be reverted locally by people using it.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21068: Remove NorwegianPatronDB related code
Jonathan Druart [Mon, 13 Aug 2018 16:49:56 +0000 (13:49 -0300)]
Bug 21068: Remove NorwegianPatronDB related code

Bug 11401 introduced code to support Norwegian national library card.
This code is too specific to be part of Koha as it, it should be a
plugin instead.
Moreover nobody uses it, but a modified version (see comment 3).

Test plan:
Add/edit/delete patron and make sure there are no regressions introduced
by these patches

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21199: (QA follow-up) Add show_attributes to perldoc
Martin Renvoize [Mon, 13 Aug 2018 08:54:44 +0000 (09:54 +0100)]
Bug 21199: (QA follow-up) Add show_attributes to perldoc

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21199: Hide patron's attributes from ILSDI if required
Jonathan Druart [Thu, 9 Aug 2018 22:34:58 +0000 (19:34 -0300)]
Bug 21199: Hide patron's attributes from ILSDI if required

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 13618: (follow-up) Manually replace missing .raw
Jonathan Druart [Fri, 24 Aug 2018 22:15:18 +0000 (19:15 -0300)]
Bug 13618: (follow-up) Manually replace missing .raw

Must be |$raw, not |raw

Error:
Template process failed: undef error - raw: filter not found at
/home/vagrant/kohaclone/C4/Templates.pm line 122

To recreate:
Add a new restriction and visit circulation.pl?borrowernumber=42

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (RM follow-up) Update schema files
Nick Clemens [Sat, 25 Aug 2018 15:16:47 +0000 (15:16 +0000)]
Bug 15524: (RM follow-up) Update schema files

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: DBRev 18.06.00.020
Nick Clemens [Fri, 24 Aug 2018 16:03:50 +0000 (16:03 +0000)]
Bug 15524: DBRev 18.06.00.020

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (RM follow-up) Fix calls and add filter
Nick Clemens [Fri, 24 Aug 2018 15:10:45 +0000 (15:10 +0000)]
Bug 15524: (RM follow-up) Fix calls and add filter

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass...
Kyle M Hall [Fri, 10 Aug 2018 14:36:36 +0000 (10:36 -0400)]
Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (QA follow-up) Respect ReservesControlBranch
Kyle M Hall [Fri, 10 Aug 2018 14:36:53 +0000 (10:36 -0400)]
Bug 15524: (QA follow-up) Respect ReservesControlBranch

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (QA follow-up) Pass max_holds at the right position in update
Marcel de Rooy [Fri, 16 Feb 2018 11:12:12 +0000 (12:12 +0100)]
Bug 15524: (QA follow-up) Pass max_holds at the right position in update

When updating max_holds should be before the categorycode in the update
query.
Things that can be found by testing :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (QA follow-up) Fix meaningless test
Marcel de Rooy [Fri, 16 Feb 2018 08:02:39 +0000 (09:02 +0100)]
Bug 15524: (QA follow-up) Fix meaningless test

The last test claims to allow a hold when branch=5 and patron=5, but look
at the preceding statements:
    $rule_branch->max_holds(5);
    $rule_branch->update();
    $rule_branch->max_holds(5);
    $rule_branch->insert();
The last insert will not be done, since the record is already present.
A create should have triggered an error on the primary key.
Obviously, we should use $rule_all.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: (QA follow-up) - Change language used
Kyle M Hall [Tue, 9 Jan 2018 19:56:46 +0000 (14:56 -0500)]
Bug 15524: (QA follow-up) - Change language used

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15524: Set limit on maximum possible holds per patron by category
Kyle M Hall [Wed, 28 Jun 2017 12:54:03 +0000 (08:54 -0400)]
Bug 15524: Set limit on maximum possible holds per patron by category

It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category).
This new rule works in conjunction with the existing branch/borrower/item rules in that Koha will use the lower of the two limits. This new rule counts all holds of all types, which prevents bib-level holds from not being counted for the purpose of these limits. This makes the most sense and was also requested by the sponsor.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Go to the circ rules editor, note the new max holds rules
   by patron category in the "Checkout limit by patron category".
   ( Should we rename this section? )
4) Create find a patron that is allowed to place a hold, count the
   number of holds that patron has. Lets make that number 'X'.
5) Set the new max holds rule to X for "All libraries"
6) Note the patron can no longer place another hold
7) Set the new max holds rule to X + 1 for the patron's home library
8) Note the patron can again place another hold
9) Set the new max holds rule to X for the patron's home library
10) Note the patron can no longer place another hold

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19039: (RM follow-up) Add filters to variables
Nick Clemens [Fri, 24 Aug 2018 12:00:54 +0000 (12:00 +0000)]
Bug 19039: (RM follow-up) Add filters to variables

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date
Maryse Simard [Fri, 20 Jul 2018 21:20:23 +0000 (17:20 -0400)]
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date

    In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

    This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists.

    Test plan:
    In the staff client and the opac:
    1) View a list containing several items
      => Notice that you can't sort by 'date added'
    2) Try to edit the list or create a new one
      => Notice you can't choose date added as the default sort order
    3) Apply the patch
    4) When viewing the list you should now be able to sort by date added
      => Make sure it orders correctly
    5) Edit or create a list and choose date added as default sorting order
      => Make sure it uses date added as default
      => On the staff client: test that the filter for 'sort by' works for date added
      => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19039: Results of virtual shelves (lists) not sortable by date
Maryse Simard [Tue, 12 Jun 2018 17:42:23 +0000 (13:42 -0400)]
Bug 19039: Results of virtual shelves (lists) not sortable by date

In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

Test plan:
1) In the staff client, view a list containing several items
2) Notice that you can't sort by 'date added'
3) Apply the patch
4) Repeat step 1
5) The list can now be sorted by 'date added'

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21209: (bug 20828 follow-up) Step 4 of moremember is used for Housebound and...
Jonathan Druart [Mon, 13 Aug 2018 18:07:05 +0000 (15:07 -0300)]
Bug 21209: (bug 20828 follow-up) Step 4 of moremember is used for Housebound and additional attributes

Test plan:

1) Make sure the HouseboundModule is enabled in system preferences
2) Go to a patron file
3) Next to Housebound roles, click on "Add"
4) Check "Yes" next to one of the two roles (or both)
5) Click "Save"
6) The "Add" button is now "Edit", click on it

The page is the one to edit housebound roles.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21239: (RM follow-up) regenerate staff css
Nick Clemens [Fri, 24 Aug 2018 11:47:29 +0000 (11:47 +0000)]
Bug 21239: (RM follow-up) regenerate staff css

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21239: CSS regressions caused by SCSS move
Owen Leonard [Fri, 17 Aug 2018 12:47:52 +0000 (12:47 +0000)]
Bug 21239: CSS regressions caused by SCSS move

This patch corrects some mistakes in staff-global.scss made during the
conversion from CSS.

To test, apply the patch and regenerate your CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.

View various forms in the staff client which have hints and required
fields, including:

- Notices & slips -> Modify notice
- Administration -> Budgets -> Modify budget

Verify that date format hints are positioned correctly. Try to submit
the form with empty required fields and verify that the "This field is
required" message is positioned correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21237: Clean up staff client SCSS
Owen Leonard [Thu, 16 Aug 2018 14:25:39 +0000 (14:25 +0000)]
Bug 21237: Clean up staff client SCSS

This patch removes a redundant linter configuration, .sass-lint.yml,
which was added by mistake.

Some linter rules have been modified to better conform to the defacto
standard set by our existing CSS.

staff-global.scss has been corrected to comply with linter rules
(https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md):

- Comment, style: silent
- TrailingSemicolon, true
- Shorthand
- ColorKeyword, enabled: true
- PropertySortOrder

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20984: Add 300$f to display
Joy Nelson [Fri, 22 Jun 2018 20:48:25 +0000 (13:48 -0700)]
Bug 20984: Add 300$f to display

Adding Type of Unit (300$f) to the Opac details and staff side searches results and details display

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 17625: adding subfields f and g to XSLT display
Joy Nelson [Fri, 22 Jun 2018 18:56:11 +0000 (11:56 -0700)]
Bug 17625: adding subfields f and g to XSLT display

Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Cab Vinton <bibliwho@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21182: Remove acqui/check_duplicate_barcode_ajax.pl
Jonathan Druart [Mon, 6 Aug 2018 18:38:58 +0000 (15:38 -0300)]
Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

It has been added by
  commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
  Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.

But its last call removed since:
  commit eefc774e274ce8167f1063be5f9204a0d5cf5650
  Bug 7178: Acquisition item creation improvement

Test plan:
  git grep check_duplicate_barcode
should not return anything

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20248: (QA follow-up) Remove unnecessary stuff
Julian Maurice [Wed, 8 Aug 2018 12:33:11 +0000 (14:33 +0200)]
Bug 20248: (QA follow-up) Remove unnecessary stuff

- Remove useless 'action' attribute in forms
- $op should never be equal to 'reset', so remove the test
- Move 'op' parameter inside <button>s to avoid having different HTML
  tags for elements that have the same kind of behaviour

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.
Ere Maijala [Mon, 19 Feb 2018 14:54:39 +0000 (16:54 +0200)]
Bug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.

Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.

To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t

Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19719: DBRev 18.06.00.019
Nick Clemens [Wed, 22 Aug 2018 13:57:02 +0000 (13:57 +0000)]
Bug 19719: DBRev 18.06.00.019

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19719: (follow-up) Add database update to keep collection column hidden
Katrin Fischer [Tue, 19 Jun 2018 22:16:38 +0000 (00:16 +0200)]
Bug 19719: (follow-up) Add database update to keep collection column hidden

For existing installations we want to keep the current behaviour.
This patch adds the column configuration to hide the collection
column from the details and checkouts tabs until toggled.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19719: (follow-up) Show description instead of code
Katrin Fischer [Sat, 31 Mar 2018 08:13:57 +0000 (10:13 +0200)]
Bug 19719: (follow-up) Show description instead of code

This follow-up changes the display from collection code
to description, following the existing pattern for
location.

To test:
- Repeat test plan from first patch
- Verfiy now the collection descrption shows
- Change column setting in administration
- Verify they work as expected

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 19719: Add new column for collection in the patron checkouts data tables
Jesse Maseto [Fri, 2 Mar 2018 13:11:44 +0000 (13:11 +0000)]
Bug 19719: Add new column for collection in the patron checkouts data tables

This makes the collection visible in the checkouts table
on the details and issues tab in the patron account in staff.

TEST:

1. Check out a few items to patron.
2. View check outs on patron account in staff client.
3. Collection code is not present.

4. Apply patch

5. Notice that not Collection code is visible while viewing check outs.

Signed-off-by: Severine QUEUNE <severine.queune@bulac.fr>
Signed-off by: Maksim Sen <maksim.sen@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15408: Fix tests to fail without patch
Nick Clemens [Tue, 7 Aug 2018 13:37:30 +0000 (13:37 +0000)]
Bug 15408: Fix tests to fail without patch

We set all the timestamps to a specified date and ensure the new budgets
don't have this date

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 15408: Remove fund's timestamp when cloning a budget
Baptiste Wojtkowski [Fri, 3 Feb 2017 15:22:36 +0000 (15:22 +0000)]
Bug 15408: Remove fund's timestamp when cloning a budget

To duplicate the budget, the function CloneBudgetHierarchy create a new budget
from the old without the parameter timestamp, so that the database generates a
new one.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Added unit tests to patch

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Modified to run properly the QA tests

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21150: add the biblionumber to the output
Jonathan Druart [Tue, 7 Aug 2018 14:14:54 +0000 (11:14 -0300)]
Bug 21150: add the biblionumber to the output

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21150: Search for item types inconsistencies
Jonathan Druart [Fri, 3 Aug 2018 17:59:33 +0000 (14:59 -0300)]
Bug 21150: Search for item types inconsistencies

search_for_data_inconsistencies.pl will now display errors if:
1.item-level_itypes is set to "specific item" and items.itype is not set
or not set to an item type defined in the system (itemtypes.itemtype)
2.item-level_itypes is set to "biblio record" and biblioitems.itemtype is not set
or not set to an item type defined in the system (itemtypes.itemtype)

Test plan:
Use the script and the different possible combinations to display the
errors

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20509: Add to script documentation
Katrin Fischer [Tue, 31 Jul 2018 16:23:43 +0000 (16:23 +0000)]
Bug 20509: Add to script documentation

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 20509: Search for not defined authority codes
Jonathan Druart [Wed, 27 Jun 2018 18:35:57 +0000 (15:35 -0300)]
Bug 20509: Search for not defined authority codes

This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for not
defined authority codes.

Test plan:
Set some auth_header.authtypecode to not defined authority codes in Koha
(UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
Then run `misc/maintenance/search_for_data_inconsistencies.pl`

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
22 months agoBug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode to...
Josef Moravec [Wed, 27 Jun 2018 20:27:09 +0000 (20:27 +0000)]
Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode to executable

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>