Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34820: Clarify inventory tool message for items with non-matching notforloan value

Browse source 
In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity.

Test plan:
1) Create two items, one of which has the NFL status of "Ordered", the
   other having no NFL status
2) Enter those two barcodes in the inventory tool barcodes list
3) Check only "Ordered" in items.notforloan
4) Note the problem messages
5) Apply this patch
6) Re-run the inventory tool
7) Note the new clarified messages!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle Hall 2023-09-18 12:02:34 -04:00 committed by Tomas Cohen Arazi
parent a3849909a9
commit 1810fac11e
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
View file

@ -149,6 +149,7 @@
<fieldset class="rows" id="optionalfilters">
<legend>Optional filters for inventory list or comparing barcodes</legend>
<span class="hint">Scanned items are expected to match one of the selected <em>not for loan</em> critera if any are checked.</span>
<br/>
<div id="statuses" style="display: block;">
[% FOREACH status IN statuses %]
@ -311,7 +312,11 @@
[% IF problem.key == 'wrongplace' %]
<span>Found in wrong place</span><br/>
[% ELSIF problem.key == 'changestatus' %]
<span>Unknown not-for-loan status</span><br/>
[% IF result.notforloan %]
<span>Item has unselected <em>Not for loan</em> status <em>[% result.notforloan %]</em></span><br/>
[% ELSE %]
<span>Items has no <em>not for loan</em> status</span><br/>
[% END %]
[% ELSIF problem.key == 'not_scanned' %]
<span>Missing (not scanned)</span><br/>
[% ELSIF problem.key == 'checkedout' %]