Browse Source

Bug 8064: Fix unit tests for createMergeHash

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
3.22.x
Julian Maurice 10 years ago
committed by Tomas Cohen Arazi
parent
commit
20636ce194
  1. 18
      t/Koha_MetadataRecord.t
  2. 18
      t/Koha_Util_MARC.t

18
t/Koha_MetadataRecord.t

@ -38,16 +38,10 @@ my $record = Koha::MetadataRecord->new({ 'record' => $marcrecord, 'schema' => 'm
is(ref($record), 'Koha::MetadataRecord', 'Created valid Koha::MetadataRecord object');
my $samplehash = [
{
'field' => [
{
'value' => '1234',
'tag' => '001',
}
]
},
{
'field' => [
{
'subfield' => [
{
@ -58,11 +52,7 @@ my $samplehash = [
'indicator2' => ' ',
'tag' => 150,
'indicator1' => ' ',
}
]
},
{
'field' => [
{
'subfield' => [
{
@ -78,16 +68,14 @@ my $samplehash = [
'tag' => 450,
'indicator1' => ' ',
}
]
}
];
my $hash = $record->createMergeHash();
my %fieldkeys;
foreach my $field (@$hash) {
$fieldkeys{delete $field->{'field'}->[0]->{'key'}}++;
if (defined $field->{'field'}->[0]->{'subfield'}) {
foreach my $subfield (@{$field->{'field'}->[0]->{'subfield'}}) {
$fieldkeys{delete $field->{'key'}}++;
if (defined $field->{'subfield'}) {
foreach my $subfield (@{$field->{'subfield'}}) {
$fieldkeys{delete $subfield->{'subkey'}}++;
}
}

18
t/Koha_Util_MARC.t

@ -37,16 +37,10 @@ $marcrecord->add_fields(
[ '450', ' ', ' ', a => 'Cookery', z => 'Instructional manuals' ],
);
my $samplehash = [
{
'field' => [
{
'value' => '1234',
'tag' => '001',
}
]
},
{
'field' => [
{
'subfield' => [
{
@ -57,11 +51,7 @@ my $samplehash = [
'indicator2' => ' ',
'tag' => 150,
'indicator1' => ' ',
}
]
},
{
'field' => [
{
'subfield' => [
{
@ -77,16 +67,14 @@ my $samplehash = [
'tag' => 450,
'indicator1' => ' ',
}
]
}
];
my $hash = Koha::Util::MARC::createMergeHash($marcrecord);
my %fieldkeys;
foreach my $field (@$hash) {
$fieldkeys{delete $field->{'field'}->[0]->{'key'}}++;
if (defined $field->{'field'}->[0]->{'subfield'}) {
foreach my $subfield (@{$field->{'field'}->[0]->{'subfield'}}) {
$fieldkeys{delete $field->{'key'}}++;
if (defined $field->{'subfield'}) {
foreach my $subfield (@{$field->{'subfield'}}) {
$fieldkeys{delete $subfield->{'subkey'}}++;
}
}

Loading…
Cancel
Save