Bug 37021: Change item_id type as integer in holds endpoint

When one makes a GET call to holds endpoint and hold has
item attached to it, item_id is handled as string not integer
as it should.

To reproduce:
1. Make sure you have hold waiting in your database.
2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}].
=> Note that holds item_id is displayed as item_id: "12345".
3. Apply this patch.
4. Call endpoint again.
=> item_id should now be displayed as 12345.

Also prove t/db_dependent/api/v1/holds.t.

Signed-off-by: Jan Kissig <jkissig@th-wildau.de>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Emmi Takkinen 2024-06-04 13:00:05 +03:00 committed by Martin Renvoize
parent 8d3c3b35e0
commit 20e0c056c6
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F

View file

@ -64,7 +64,7 @@ properties:
description: Timestamp for the latest hold update
item_id:
type:
- string
- integer
- "null"
description: Internal item identifier
waiting_date: