Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32634: Add 'page-section' to various pages

Browse source 
This patch adds a "page-section" container div around the main section
of various pages which lack it.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

Apply the patch and view the following pages to confirm that the main
content is contained in a white box:

- Locate a patron who has one or more account transactions.
  - Go to the Accounting tab -> Transactions. Click "Details" on one of
      the lines.
    - The "Details of debit" and "History" sections should be wrapped in
      .page-section.
- Go to Tools -> Patron card creator -> Manage -> Batches
  - If there is not a list of batches you will need to create at least
    one to see the page-section container.
- Go to Reports -> View dictionary.
  - If necessary, add a definition.
  - The "Current terms" table should be wrapped in .page-section.
- Go to Lists and view the contents of a list with one or more titles on
  it. The table of titles should be wrapped in .page-section.
- Go to Circulation -> Upload offline circulation file (.koc)
  - Upload a .koc file and click the "Add to offline circulation queue."
  - On the confirmation page the "Your file was uploaded" message should
    be wrapped in .page-section.
  - Click "View pending offline circulation actions"
    - The list of pending actions should be wrapped in .page-section

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-01-13 20:15:13 +00:00 committed by Tomas Cohen Arazi
parent 8a63e6eecc
commit 4573e5ff91
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
6 changed files with 271 additions and 260 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
View file

@ -167,6 +167,7 @@
<div class="page-section">
<h3>History</h3>
<table class="accountline-offsets-table" id="accountline-debits-table">
<thead>
<tr>

15
koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
View file

@ -28,21 +28,22 @@
<div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
<h1>Koha offline circulation</h1>
<div class="page-section">
<p>Your file was uploaded. Once all files are uploaded, please process them in pending offline circulation actions.</p>
[% FOREACH message IN messages %]
[% FOREACH message IN messages %]
[% IF ( message.message ) %]
[% IF ( message.ERROR_file_version ) %]
<div class="dialog alert"><p>Warning: This file is version [% message.upload_version | html %], but I only know how to import version [% message.current_version | html %]. I'll try my best.</p>
<div class="dialog alert"><p>Warning: This file is version [% message.upload_version | html %], but I only know how to import version [% message.current_version | html %]. I'll try my best.</div>
[% END %]
[% END %]
[% END %]
[% END %]
<p><a href="process_koc.pl">Upload another KOC file</a></p>
<p><a href="list.pl">View pending offline circulation actions</a></p>
<p><a href="process_koc.pl">Upload another KOC file</a></p>
<p><a href="list.pl">View pending offline circulation actions</a></p>
</div> <!-- /.page-section -->
</div>
</div>
</div>
[% INCLUDE 'intranet-bottom.inc' %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt
View file

@ -43,6 +43,7 @@
<a id="CheckNone" href="#"><i class="fa fa-remove"></i> Uncheck all</a>
</p>
<div class="page-section">
<table id="operations">
<thead>
<tr>
@ -94,6 +95,7 @@
[% END %]
</tbody>
</table>
</div> <!-- /.page-section -->
<p id="actions">For the selected operations:
<input type="button" id="process" value="Process" />

2
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
View file

@ -67,6 +67,7 @@
<div id="manage-patroncards-layouts">
[% IF ( table_loop ) %]
<form name="layouts" action="/cgi-bin/koha/manage.pl?card_element=[% card_element | html %]">
<div class="page-section">
<h2>Currently available [% PROCESS translate_card_element element=card_element_title FILTER lower %]</h2>
<table>
[% FOREACH table_loo IN table_loop %]
@ -114,6 +115,7 @@
<fieldset class="action">
[% IF ( print ) %]<input type="button" id="print" value="Export selected batches" />[% END %]
</fieldset>
</div> <!-- /.page-section -->
[% IF patron_lists %]
<fieldset class="rows">
<legend>Or use a patron list</legend>

2
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt
View file

@ -110,6 +110,7 @@
<p>Use the dictionary to define custom criteria for reporting.</p>
[% IF ( definitions ) %]
<div class="page-section">
<h2>Current terms</h2>
<form action="/cgi-bin/koha/reports/dictionary.pl" method="post">
<input type="hidden" name="phase" value="View Dictionary" />
@ -151,6 +152,7 @@
</tr>
[% END %]
</table>
</div> <!-- /.page-section -->
[% ELSE %]
<div class="dialog message">There are no saved definitions. <a id="newdictionary" href="/cgi-bin/koha/reports/dictionary.pl?phase=Add%20New%20Definition">Add a definition to the dictionary.</a></div>
[% END %]

3
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
View file

@ -281,6 +281,7 @@
</div>
[% END %]
<div class="page-section">
<table id="searchresults" class="dataTable">
<thead>
<tr>
@ -389,6 +390,8 @@
</tr>
[% END #/FOREACH itemsloo %]
</table> <!-- /#searchresults -->
</div> <!-- /.page-section -->
<div class="pages">[% pagination_bar | $raw %]</div>
</form>
[% END # /IF itemsloop %]