Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15839: Koha::Reviews - Remove getreview

Browse source 
Note that this (biblionumber, borrowernumber) pair should be defined as
a unique key at the DB level (FIXME added)

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-02-16 16:15:55 +00:00 committed by Kyle M Hall
parent f3b57dfb02
commit 48fe93e945
2 changed files with 8 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
C4/Review.pm
View file

@ -27,7 +27,7 @@ use vars qw(@ISA @EXPORT);
BEGIN {
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(getreview savereview updatereview numberofreviews numberofreviewsbybiblionumber);
@EXPORT = qw(savereview updatereview numberofreviews numberofreviewsbybiblionumber);
}
=head1 NAME
@ -38,7 +38,6 @@ C4::Review - Perl Module containing routines for dealing with reviews of items
use C4::Review;
my $review=getreview($biblionumber,$borrowernumber);
savereview($biblionumber,$borrowernumber,$review);
updatereview($biblionumber,$borrowernumber,$review);
my $count=numberofreviews($status);
@ -50,23 +49,6 @@ Review.pm provides many routines for manipulating reviews.
=head1 FUNCTIONS
=head2 getreview
$review = getreview($biblionumber,$borrowernumber);
Takes a borrowernumber and a biblionumber and returns the review of that biblio
=cut
sub getreview {
my ( $biblionumber, $borrowernumber ) = @_;
my $dbh = C4::Context->dbh;
my $query = "SELECT * FROM reviews WHERE biblionumber=? and borrowernumber=?";
my $sth = $dbh->prepare($query);
$sth->execute( $biblionumber, $borrowernumber );
return $sth->fetchrow_hashref();
}
=head2 savereview
savereview($biblionumber,$borrowernumber, $review);

11
opac/opac-review.pl
View file

@ -17,8 +17,7 @@
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth;
use C4::Koha;
@ -27,6 +26,7 @@ use C4::Review;
use C4::Biblio;
use C4::Scrubber;
use C4::Debug;
use Koha::Reviews;
my $query = new CGI;
my $biblionumber = $query->param('biblionumber');
@ -43,7 +43,8 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
# FIXME: need to allow user to delete their own comment(s)
my $biblio = GetBiblioData($biblionumber);
my $savedreview = getreview($biblionumber,$borrowernumber);
# FIXME biblionumber, borrowernumber should be a unique key of reviews
my $savedreview = Koha::Reviews->search({ biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next;
my ($clean, @errors);
if (defined $review) {
if ($review !~ /\S/) {
@ -70,10 +71,12 @@ if (defined $review) {
}
(@errors ) and $template->param( ERRORS=>\@errors);
($cgi_debug) and $template->param(cgi_debug=>1 );
$review = $clean;
$review ||= $savedreview->review if $savedreview;
$template->param(
'biblionumber' => $biblionumber,
'borrowernumber' => $borrowernumber,
'review' => $clean || $savedreview->{'review'},
'review' => $review,
'reviewid' => scalar $query->param('reviewid') || 0,
'title' => $biblio->{'title'},
);