Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37089: cud-delete_confirm should not be cud

Browse source 
Adjust aqbudgets.pl and currency.pl to check for the correct op value

To test:
Part 1 - Delete a fund
1. Go to Acquisitions > Funds
2. Try to delete a fund
   --> Confirmation page shows fund name as '' and fund amount as 0.00
3. Click "Yes, delete this fund"
   --> The fund is still there

Part 2 - Delete a currency
3. Go to Acquisitions > Currencies
4. Try to delete a currency
   --> Confirmation shows empty values for currency and rate
5. Click, "Yes, delete this currency"
   --> An error message appears and the currency is not deleted

6. Apply patch and restart_all
7. Repeat steps 1-5
   --> Confirmation pages display correct information, and deletions
       occur successfully

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Emily Lamancusa 2024-06-14 10:03:22 -04:00 committed by Katrin Fischer
parent c81b201dc9
commit 5083d5752c
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
admin/aqbudgets.pl
View file

@ -185,7 +185,7 @@ if ($op eq 'add_form') {
#---------------------- DEFAULT DISPLAY BELOW ---------------------
# called by default form, used to confirm deletion of data in DB
} elsif ($op eq 'cud-delete_confirm') {
} elsif ($op eq 'delete_confirm') {
my $budget = GetBudget($budget_id);
$template->param(

2
admin/currency.pl
View file

@ -91,7 +91,7 @@ if ( $op eq 'add_form' ) {
}
$searchfield = q||;
$op = 'list';
} elsif ( $op eq 'cud-delete_confirm' ) {
} elsif ( $op eq 'delete_confirm' ) {
my $currency = Koha::Acquisition::Currencies->find($currency_code);
my $nb_of_orders = Koha::Acquisition::Orders->search( { currency => $currency->currency } )->count;