Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29105: Unit test

Browse source 
This patch adds a unit test for the addition of effective_item_type_id
to the items responses.

Test plan
1) Run the unit test prior to applying the second patch and confirm it
   fails
2) Apply the second patch and confirm the unit test now passes

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2021-09-24 15:13:55 +01:00 committed by Tomas Cohen Arazi
parent 3f3a1b702c
commit 6ca908816f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
t/db_dependent/api/v1/items.t
View file

@ -101,7 +101,7 @@ subtest 'list() tests' => sub {
subtest 'get() tests' => sub {
plan tests => 9;
plan tests => 17;
$schema->storage->txn_begin;
@ -139,6 +139,26 @@ subtest 'get() tests' => sub {
->status_is(404)
->json_is( '/error' => 'Item not found' );
t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
my $biblio = $builder->build_sample_biblio;
my $itype =
$builder->build_object( { class => 'Koha::ItemTypes' } )->itemtype;
$item = $builder->build_sample_item(
{ biblionumber => $biblio->biblionumber, itype => $itype } );
$t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber )
->status_is( 200, 'SWAGGER3.2.2' )
->json_is( '/item_type_id' => $itype, 'item-level_itypes:0' )
->json_is( '/effective_item_type_id' => $biblio->itemtype, 'item-level_itypes:0' );
t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
$t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber )
->status_is( 200, 'SWAGGER3.2.2' )
->json_is( '/item_type_id' => $itype, 'item-level_itype:1' )
->json_is( '/effective_item_type_id' => $itype, 'item-level_itypes:1' );
$schema->storage->txn_rollback;
};