Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35402: Fix regressions.t

Browse source 
The audio alert feature is not correctly designed and is problematic.
It looks at the class name in the DOM, not when the element with this class name
will be displayed to the end user

So it's not possible to make it work for modals for instance, or if an element
is built in JS then displayed

This patch remove the modal code from the code, if there are no waiting
holds. It is the behaviour that existed prior to the Bootstrap update.
However it is kind of random behaviour, the song that is played when the
librarian open the circ page is different if the user has waiting holds or not.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-09-03 11:03:17 +02:00 committed by Katrin Fischer
parent 7e5a2f5a4d
commit 95ff9ad02d
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
View file

@ -963,7 +963,7 @@
</div> <!-- /.modal-dialog -->
</div> <!-- /#barcodeSubmittedModal -->
[% #IF waiting_holds.count > 0 %]
[% IF waiting_holds.count > 0 %]
<div id="circ-warnwaitingholds-modal" class="modal audio-alert-action block">
<div class="modal-dialog">
<div class="modal-content">
@ -983,7 +983,7 @@
</div>
</div>
</div>
[% #END %]
[% END %]
[% INCLUDE modals/cancel_booking.inc %]
[% MACRO jsinclude BLOCK %]