Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin

This patch makes minor changes to the text of hold confirmation buttons
in the checkin process in order to make them more consistent.

Also changed: Removed the "danger" class from the "Ignore" button for
readability and consistency's sake.

To test, apply the patch and check in an item which is on hold for a
patron at your logged-in library. The hold confirmation dialog's buttons
should read "Confirm hold," "Print slip and confirm," and "Ignore."

Confirm the hold, then check in the same item again.

In the dialog, the buttons should read "Confirm hold," "Print slip and
confirm," and "Cancel hold."

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2018-10-05 17:05:19 +00:00 committed by Nick Clemens
parent 40803d3035
commit 96c2df5804

View file

@ -276,12 +276,12 @@
<input type="hidden" name="cancel_reserve" value="0" />
<button type="submit" class="btn btn-default approve" data-dismiss="modal">
<i class="fa fa-check"></i> Confirm
<i class="fa fa-check"></i> Confirm hold
</button>
<input type="hidden" name="print_slip" value="0" />
<button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();">
<i class="fa fa-print"></i> Print and confirm
<i class="fa fa-print"></i> Print slip and confirm
</button>
<button type="submit" class="btn btn-default deny" onclick="this.form.cancel_reserve.value = 1; this.form.submit();">
@ -497,7 +497,7 @@
</button>
[% END %]
<button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-danger deny" onclick="$('#barcode').focus(); return false;">
<button data-dismiss="modal" aria-hidden="true" type="submit" class="btn btn-default deny" onclick="$('#barcode').focus(); return false;">
<i class="fa fa-times"></i> Ignore
</button>
</div>