Koha-community
/
Koha
13
5
Fork 0
Code Issues Releases Wiki Activity
Browse Source

Bug 27587: Use Basic auth on API tests - patrons_password.t 

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
21.05.x
Tomás Cohen Arazi 3 years ago
committed by Jonathan Druart
parent
db2c902f28
commit
9bcc859617
1 changed files with 106 additions and 155 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 261
      t/db_dependent/api/v1/patrons_password.t

261
t/db_dependent/api/v1/patrons_password.t
View File

@ -20,7 +20,6 @@ use Modern::Perl;
use Test::More tests => 2; use Test::More tests => 2;
use Test::Mojo; use Test::Mojo;
use Test::Warn;
use t::lib::TestBuilder; use t::lib::TestBuilder;
use t::lib::Mocks; use t::lib::Mocks;
@ -30,12 +29,9 @@ use Koha::Patrons;
my $schema = Koha::Database->new->schema; my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new; my $builder = t::lib::TestBuilder->new;
# FIXME: sessionStorage defaults to mysql, but it seems to break transaction handling t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
# this affects the other REST api tests
t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' );
my $remote_address = '127.0.0.1'; my $t = Test::Mojo->new('Koha::REST::V1');
my $t = Test::Mojo->new('Koha::REST::V1');
subtest 'set() (authorized user tests)' => sub { subtest 'set() (authorized user tests)' => sub {
@ -43,80 +39,78 @@ subtest 'set() (authorized user tests)' => sub {
$schema->storage->txn_begin; $schema->storage->txn_begin;
my ( $patron, $session ) = create_user_and_session({ authorized => 1 }); my $privileged_patron = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 1 }
}
);
my $password = 'thePassword123';
$privileged_patron->set_password(
{ password => $password, skip_validation => 1 } );
my $userid = $privileged_patron->userid;
my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
t::lib::Mocks::mock_preference( 'minPasswordLength', 3 ); t::lib::Mocks::mock_preference( 'minPasswordLength', 3 );
t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 ); t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
my $new_password = 'abc'; my $new_password = 'abc';
my $tx $t->post_ok( "//$userid:$password@/api/v1/patrons/"
= $t->ua->build_tx( POST => "/api/v1/patrons/" . $patron->id
. $patron->id . "/password" => json =>
. "/password" => json => { password => $new_password, password_2 => $new_password } ); { password => $new_password, password_2 => $new_password } )
->status_is(200)->json_is('');
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $t->post_ok( "//$userid:$password@/api/v1/patrons/"
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); . $patron->id
$t->request_ok($tx)->status_is(200)->json_is( '' ); . "/password" => json =>
{ password => $new_password, password_2 => 'cde' } )->status_is(400)
$tx ->json_is( { error => 'Passwords don\'t match' } );
= $t->ua->build_tx( POST => "/api/v1/patrons/"
. $patron->id
. "/password" => json => { password => $new_password, password_2 => 'cde' } );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx)->status_is(400)->json_is({ error => 'Passwords don\'t match' });
t::lib::Mocks::mock_preference( 'minPasswordLength', 5 ); t::lib::Mocks::mock_preference( 'minPasswordLength', 5 );
$tx
= $t->ua->build_tx( POST => "/api/v1/patrons/"
. $patron->id
. "/password" => json => { password => $new_password, password_2 => $new_password } );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $t->post_ok( "//$userid:$password@/api/v1/patrons/"
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); . $patron->id
$t->request_ok($tx)->status_is(400)->json_is({ error => 'Password length (3) is shorter than required (5)' }); . "/password" => json =>
{ password => $new_password, password_2 => $new_password } )
->status_is(400)
->json_is(
{ error => 'Password length (3) is shorter than required (5)' } );
$new_password = 'abc '; $new_password = 'abc ';
$tx $t->post_ok( "//$userid:$password@/api/v1/patrons/"
= $t->ua->build_tx( POST => "/api/v1/patrons/" . $patron->id
. $patron->id . "/password" => json =>
. "/password" => json => { password => $new_password, password_2 => $new_password } ); { password => $new_password, password_2 => $new_password } )
->status_is(400)->json_is(
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); {
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); error =>
$t->request_ok($tx)->status_is(400)->json_is({ error => '[Password contains leading/trailing whitespace character(s)]' }); '[Password contains leading/trailing whitespace character(s)]'
}
);
$new_password = 'abcdefg'; $new_password = 'abcdefg';
$tx $t->post_ok( "//$userid:$password@/api/v1/patrons/"
= $t->ua->build_tx( POST => "/api/v1/patrons/" . $patron->id
. $patron->id . "/password" => json =>
. "/password" => json => { password => $new_password, password_2 => $new_password } ); { password => $new_password, password_2 => $new_password } )
->status_is(200)->json_is('');
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); t::lib::Mocks::mock_preference( 'RequireStrongPassword', 1 );
$t->request_ok($tx)->status_is(200)->json_is(''); $t->post_ok( "//$userid:$password@/api/v1/patrons/"
. $patron->id
t::lib::Mocks::mock_preference( 'RequireStrongPassword', 1); . "/password" => json =>
$tx { password => $new_password, password_2 => $new_password } )
= $t->ua->build_tx( POST => "/api/v1/patrons/" ->status_is(400)->json_is( { error => '[Password is too weak]' } );
. $patron->id
. "/password" => json => { password => $new_password, password_2 => $new_password } );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx)->status_is(400)->json_is({ error => '[Password is too weak]' });
$new_password = 'ABcde123%&'; $new_password = 'ABcde123%&';
$tx $t->post_ok( "//$userid:$password@/api/v1/patrons/"
= $t->ua->build_tx( POST => "/api/v1/patrons/" . $patron->id
. $patron->id . "/password" => json =>
. "/password" => json => { password => $new_password, password_2 => $new_password } ); { password => $new_password, password_2 => $new_password } )
->status_is(200)->json_is('');
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx)->status_is(200)->json_is('');
$schema->storage->txn_rollback; $schema->storage->txn_rollback;
}; };
@ -127,8 +121,11 @@ subtest 'set_public() (unprivileged user tests)' => sub {
$schema->storage->txn_begin; $schema->storage->txn_begin;
my ( $patron, $session ) = create_user_and_session({ authorized => 0 }); my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
my $other_patron = $builder->build_object({ class => 'Koha::Patrons' }); my $password = 'thePassword123';
$patron->set_password( { password => $password, skip_validation => 1 } );
my $userid = $patron->userid;
my $other_patron = $builder->build_object( { class => 'Koha::Patrons' } );
# Enable the public API # Enable the public API
t::lib::Mocks::mock_preference( 'RESTPublicAPI', 1 ); t::lib::Mocks::mock_preference( 'RESTPublicAPI', 1 );
@ -139,118 +136,72 @@ subtest 'set_public() (unprivileged user tests)' => sub {
my $new_password = 'abc'; my $new_password = 'abc';
my $tx = $t->ua->build_tx( $t->post_ok(
POST => "/api/v1/public/patrons/" "//$userid:$password@/api/v1/public/patrons/"
. $patron->id . $patron->id
. "/password" => json => { . "/password" => json => {
password => $new_password, password => $new_password,
password_repeated => $new_password, password_repeated => $new_password,
old_password => 'blah' old_password => 'blah'
} }
)->status_is(403)->json_is(
{
error =>
'Configuration prevents password changes by unprivileged users'
}
); );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx)
->status_is(403)
->json_is({
error => 'Configuration prevents password changes by unprivileged users'
});
t::lib::Mocks::mock_preference( 'OpacPasswordChange', 1 ); t::lib::Mocks::mock_preference( 'OpacPasswordChange', 1 );
my $password = 'holapassword'; $t->post_ok(
$patron->set_password({ password => $password }); "//$userid:$password@/api/v1/public/patrons/"
$tx = $t->ua->build_tx( . $other_patron->id
POST => "/api/v1/public/patrons/" . "/password" => json => {
. $other_patron->id
. "/password" => json => {
password => $new_password, password => $new_password,
password_repeated => $new_password, password_repeated => $new_password,
old_password => $password old_password => $password
} }
); )->status_is(403)
->json_is( '/error',
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); "Authorization failure. Missing required permission(s)." );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx) $t->post_ok(
->status_is(403) "//$userid:$password@/api/v1/public/patrons/"
->json_is('/error', "Authorization failure. Missing required permission(s)."); . $patron->id
. "/password" => json => {
$tx = $t->ua->build_tx(
POST => "/api/v1/public/patrons/"
. $patron->id
. "/password" => json => {
password => $new_password, password => $new_password,
password_repeated => 'wrong_password', password_repeated => 'wrong_password',
old_password => $password old_password => $password
} }
)->status_is(400)->json_is(
{
error => "Passwords don't match"
}
); );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $t->post_ok(
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); "//$userid:$password@/api/v1/public/patrons/"
$t->request_ok($tx) . $patron->id
->status_is(400) . "/password" => json => {
->json_is({
error => "Passwords don't match"
});
$tx = $t->ua->build_tx(
POST => "/api/v1/public/patrons/"
. $patron->id
. "/password" => json => {
password => $new_password, password => $new_password,
password_repeated => $new_password, password_repeated => $new_password,
old_password => 'badpassword' old_password => 'badpassword'
} }
)->status_is(400)->json_is(
{
error => "Invalid password"
}
); );
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $t->post_ok(
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } ); "//$userid:$password@/api/v1/public/patrons/"
$t->request_ok($tx) . $patron->id
->status_is(400) . "/password" => json => {
->json_is({
error => "Invalid password"
});
$tx = $t->ua->build_tx(
POST => "/api/v1/public/patrons/"
. $patron->id
. "/password" => json => {
password => $new_password, password => $new_password,
password_repeated => $new_password, password_repeated => $new_password,
old_password => $password old_password => $password
} }
); )->status_is(200)->json_is('');
$tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
$tx->req->env( { REMOTE_ADDR => '127.0.0.1' } );
$t->request_ok($tx)
->status_is(200)
->json_is('');
$schema->storage->txn_rollback; $schema->storage->txn_rollback;
}; };
sub create_user_and_session {
my ( $args ) = @_;
my $flags = ( $args->{authorized} ) ? 16 : 0;
my $user = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => $flags }
}
);
# Create a session for the authorized user
my $session = C4::Auth::get_session('');
$session->param( 'number', $user->borrowernumber );
$session->param( 'id', $user->userid );
$session->param( 'ip', '127.0.0.1' );
$session->param( 'lasttime', time() );
$session->flush;
return ( $user, $session );
}

Write Preview
Loading…
Cancel
Save