Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34041: (follow-up) escape double dashes to prevent issues

Browse source 
Having double dashes inside a commmented block is not valid XML. This
patch restores it, with an added message explaining it

To test:
1. Run:
   $ xmllint etc/z3950/config.xml
=> FAIL: You get:
etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!--
  <config>
      <z3950_responder_options>
      <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options
2. Apply this patch
3. Repeat 1
=> SUCCESS: All good!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 11c69496bc)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Tomás Cohen Arazi 2024-05-10 09:30:53 -03:00 committed by Fridolin Somers
parent 7773b92a0c
commit afb9cd8e1c
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
etc/z3950/config.xml
View file

@ -1,8 +1,10 @@
<yazgfs> <yazgfs>
<!-- See z3950_responder.pl for available options. The options -c, -u and -p are already passed automatically by koha-z3950-responder --> <!-- See z3950_responder.pl for available options. The options -c, -u and -p are
already passed automatically by koha-z3950-responder, note that dashes for the
add-item-status switch are escaped for XML compliance but should not if uncommented -->
<!-- <!--
<config> <config>
<z3950_responder_options>--add-item-status k -t 5</z3950_responder_options> <z3950_responder_options>\-\-add-item-status k -t 5</z3950_responder_options>
</config> </config>
--> -->