Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header

Browse source 
This patch makes changes to the patron attribute types administration
template so that the page title, breadcrumb navigation, and page headers
are more consistent with each other and with other parts of Koha.

To test, apply the patch and go to Administration -> Patron attribute
types. Test these versions of the page to confirm that the breadcrumbs
and page title are consistent with each other:

- Main view
- New patron attribute type
- Edit patron attribute type
- Confirm deletion of attribute type

Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-08-18 10:40:49 +00:00 committed by Tomas Cohen Arazi
parent 160bfe32ad
commit d92f033cfc
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
View file

@ -10,9 +10,9 @@
<title>[% FILTER collapse %]
[% IF ( attribute_type_form ) %]
[% IF ( edit_attribute_type ) %]
[% t("Modify patron attribute type") | html %] &rsaquo;
[% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %] &rsaquo;
[% ELSE %]
[% t("Add patron attribute type") | html %] &rsaquo;
[% t("New patron attribute type") | html %] &rsaquo;
[% END %]
[% END %]
[% IF ( delete_attribute_type_form ) %]
@ -45,15 +45,15 @@
[% IF ( attribute_type_form ) %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
[% IF ( edit_attribute_type ) %]
<span>Modify patron attribute type</span>
[% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %]
[% ELSE %]
<span>Add patron attribute type</span>
<span>New patron attribute type</span>
[% END %]
[% END %]
[% ELSIF ( delete_attribute_type_form ) %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Confirm deletion of patron attribute type '[% code | html %]'</span>
[% tx("Confirm deletion of patron attribute type '{code}'", { code = code }) | html %]
[% END %]
[% ELSE %]
@ -75,9 +75,9 @@
[% IF ( attribute_type_form ) %]
[% IF ( edit_attribute_type ) %]
<h1>Modify patron attribute type</h1>
<h1>[% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %]</h1>
[% ELSE %]
<h1>Add patron attribute type</h1>
<h1>New patron attribute type</h1>
[% END %]
[% IF ( duplicate_code_error ) %]
<div class="dialog message">Could not add patron attribute type &quot;[% duplicate_code_error | html %]&quot;
@ -247,7 +247,9 @@
[% IF ( delete_attribute_type_form ) %]
<div class="dialog alert">
<h1>Confirm deletion of patron attribute type <span class="ex">'[% code | html %]' ([% description | html %])</span>?</h1>
<h1>
[% tx("Confirm deletion of patron attribute type '{code}' ({description})?", { code = code, description = description }) | html %]
</h1>
<form action="[% script_name | html %]" name="Aform" method="post">
<input type="hidden" name="op" value="[% confirm_op | html %]" />
<input type="hidden" name="code" value="[% code | html %]" />