Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	b1ba7fac2c	Bug 18292: Remove return 1 statements in tests The test files do not need to return 1 Patch generated with: perl -p -i -e "s/^1;\n//xsm" t/*/.t Test plan: git grep '^1;$' t/*/.t should not return any results NOTE: does not fix C4/SIP/t, nor xt tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	1917e0c89f	Bug 18851: Fix few other tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Olli-Antti Kivilahti	8bf72439c0	Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication Is 'instantiations' even a word? Use a Test::DBIx::Class defaults instead. Save your keyboard and prevent horrible bugs from emerging from rampant code duplication. This change doesn't seem to have any impact on the speed of executing those tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Jonathan Druart	2e315c0cc6	Bug 18089: Remove warnings from tests using DBIx::Class fixtures Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Kyle Hall	99cc3bdd0e	Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	7 years ago
Jonathan Druart	752c8bf043	Bug 13276: use t::lib::Mocks::mock_dbh To use this patch, patch from bug 13274 should be applied too. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	206157beb1	Bug 13276: t/XSLT.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/XSLT.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/XSLT.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass without db connection for me now. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Galen Charlton	b0eeb00d48	bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Magnus Enger	d15790d9c5	Bug 5327: Add basic unit tests to some C4 modules Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Katrin Fischer	cc9a34c274	Bug 5327: Add basic unit tests to some C4 modules Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	14 years ago
Joe Atzberger	a1fe32d2f8	Total Test Overhaul! Most of these were stubs, and still are. Input.t was replaced because it tested a now obsolete function. Input.pm has that function commented out. Several files were renamed to match their counterparts or correct misspellingz. Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
rangi	77618f43cf	Finishing up the last of the tests	17 years ago
rangi	07b3e3c952	Continuing to add tests	17 years ago
rangi	07902f96e8	Working on unit tests	17 years ago

9 Commits (04a4a34d6e9b7a235ae238b82b991795ca5abb8a)