Commit graph

8973 commits

Author SHA1 Message Date
05c5500e4f Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:07 -05:00
b43c829027 More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:36:05 -05:00
5714dc3fb5 Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 17:21:03 -05:00
Danny Bouman
83b8cfb1ad bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:48:22 -05:00
Galen Charlton
85a883ef28 fixing permission 2008-09-02 16:34:41 -05:00
Michael Hafen
cc2cffdee9 change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:34:14 -05:00
Michael Hafen
9891a955e0 Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:53 -05:00
Michael Hafen
0e3302e78b Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:33:51 -05:00
Henri-Damien LAURENT
365520159f modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:24:29 -05:00
Galen Charlton
6337b20087 bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.

Documentation changes: none per se.  However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:06:48 -05:00
8a6125532c Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 16:00:30 -05:00
ba4c13a559 Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:55:54 -05:00
730ef80520 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:43:29 -05:00
Michael Hafen
0543a9633c If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-02 15:38:16 -05:00
Galen Charlton
0fb1c26d1c Revert "If itemnumber is sent to catalogue/moredetail.pl use it"
Applied wrong version of patch.  Oops.

This reverts commit 9eb1465b28.
2008-09-02 15:36:02 -05:00
Joe Atzberger
aa4c6ff62f Fines fixes: apparent problems with fines prevent processing.
CalcFine returned values that mismatched expectations in fines.pl.

fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.

Calendar exported "new" erroneously.  I also cleaned up the queries to
avoid needlessly compiling additional statement handles.

Please test and consider application to 3.0 maintenance.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-29 20:31:41 -05:00
Michael Hafen
9eb1465b28 If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.

This patch makes moredetail.pl show only the item specified by itemnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-28 09:45:42 -05:00
Galen Charlton
6f295f997e bug 2466: fix clearing item field
When editing an item in the cataloging and serials
item editors, clearing a field now works.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-28 09:23:04 -05:00
Galen Charlton
cf8625c876 bug 2466: regression test
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-28 09:22:57 -05:00
Joe Atzberger
586e8b0869 Usage option correction (-h not -n)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-28 09:22:55 -05:00
Joe Atzberger
a01f4056f1 Minor SIP cleanup, conditionalize warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:55:00 -05:00
Joe Atzberger
1e284039c1 Bug 2419: require Exporter
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:51:18 -05:00
Galen Charlton
b31859946b bug 2552: correct issue history display
The loan history for a bib can be incorrect if the bib's
biblioitemnumber is not the same as its biblionumber.
This was due to a bad join in GetBiblioIssues().

Credit to Michael Hafen for patching a similar bug,
which inspired me to check for other bad joins.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:46:38 -05:00
MJ Ray
86d1c1d759 Update INSTALL.debian to mention a2dissite default
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:44:53 -05:00
79819e0b24 Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-27 09:35:35 -05:00
Jesse Weaver
5d0f0027be fix number two for bug 1204: Lists of issues and overdues on opac-user.pl
This makes opac-user.pl sort the output from GetPendingIssues itself, by descend
ing due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 12:20:01 -05:00
Michael Hafen
c1c49472f4 bug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns
the sql seems to assume that biblionumber and biblioitemnumber are always the same, which in my case they aren't.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:51:40 -05:00
fe04cf015e Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:39:03 -05:00
61e8d4f1c8 Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:30:48 -05:00
d42a2a86a8 Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:29:26 -05:00
Galen Charlton
25d05c8ba6 bug 2545: fix XSLTDetailsDisplay
Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-25 11:29:24 -05:00
Jesse Weaver
9389ef50ee Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-22 11:15:25 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:55:02 -05:00
Galen Charlton
c9d7c42a60 bug 2540: allow download of report
$error return C4::Reports::execute_query is
always defined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:50:16 -05:00
Jesse Weaver
a4ee974e04 fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 18:50:04 -05:00
Joe Atzberger
225e115a85 issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:43 -05:00
Jesse Weaver
7da895cda7 fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:29 -05:00
Jesse Weaver
e957b3d3c7 fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:23 -05:00
Jesse Weaver
adc5d83421 Fix for minor error in shelfbrowser queries
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:50:11 -05:00
Jesse Weaver
c77969022b fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-21 16:49:49 -05:00
Vincent Danjean
5879ead901 Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:54 -05:00
Vincent Danjean
c52357edc6 Still fixing permission and first line of scripts
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:54 -05:00
Vincent Danjean
2a9d85eade No 'BOM' marker for a script file
'#!' must be the first characters

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:54 -05:00
Vincent Danjean
d9ac3b3d33 Shebang line must be the first of the file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:53 -05:00
Vincent Danjean
908724984a Add support for DESTDIR
Distributions (such as Debian) needs a staging area when building the package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 20:23:53 -05:00
Galen Charlton
98dc396b9b bug 2503: fix minor XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Galen Charlton
41af135b31 bug 2503: comment out unneeded warns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Galen Charlton
7c646bbaa6 bug 2503: fix call to AddIssue()
The due date parameter must be a C4::Dates object,
not a date string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 19:27:48 -05:00
Andrew Moore
556d9cc43d bug 2503: refactoring and bugfixing on create_koc_db.pl
This is the script that generates the patron and holdings database for the offline circ module. I
touched up a few parts of it:

* fixed the database syntax to squash a bug or two
* extracted some methods for readability and reuse
* added some documentation
* added a --file and --force command line argument
* made it die if DBD::SQLite is not present. That module is required for this feature.

Here's an example crontab line that will generate the borrowers.db file each midnight.

0 0 * * * create_koc_db.pl --file /tmp/borrowers.db

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 17:05:25 -05:00
Andrew Moore
8c4a44ed67 bug 2503: moving offline circulation db generator to misc/cronjobs directory
This script generates a sqlite database of patron and holdings data for the offline circulation tool.
It's a cronjob, so it should go into misc/cronjobs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-08-20 17:05:25 -05:00