Commit graph

9774 commits

Author SHA1 Message Date
Ryan Higgins
09a5613586 Revert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"
This reverts commit 257a439daf.
This patch causes Bug 3195 .

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:18:37 -05:00
Nahuel ANGELINETTI
5bfee71513 (bug #3190) allow right truncation in lot of records
This patch just add an option to zebra-biblios.cfg that allow to make right truncate requests on a huge request.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 11:09:14 -05:00
Jane Wagner
3fa269da6c Bug 3173 Place Hold link visible in OPAC even if syspref turned off
If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page.  However, the link is still present in the results
list as well as in the basket and in lists.  Modified templates to check
for the syspref and to obey it.

NOTE:  This does not turn off the display of the Holds tab in the OPAC
user account.  I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC.  Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds.  It does allow users to cancel
holds.  If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:39:23 -05:00
Nahuel ANGELINETTI
348d471fe0 (bug #3187) authority search pagination doesn't work
this patch just set a marclist argument value on search authority, else the pagination won't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:23:58 -05:00
Nahuel ANGELINETTI
78756abc37 (bug #3174) show the member name in reports
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 10:17:30 -05:00
Michael Hafen
e5120778c7 Tweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL
Add the ofline_circ directory to Makefile.PL as needing to be installed.
Add calls to barcodedecode() on issueing and returning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 09:09:53 -05:00
Galen Charlton
80eecc3f19 bug 2287: handle case where autoMemberNum is off
When importing a patron file where new records
do not have a card number *and* autoMemberNum is
off, make sure that bororwers.cardnumber is set to NULL
for those new patrons rather than '' - otherwise, only
one patron with an empty barcode can be created, as there is
a uniqueness constraint on borrowers.cardnumber

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 08:46:43 -05:00
MJ Ray
9fb2d09ffc Allow autogenerated cardnumbers again to solve http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2287
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 08:26:28 -05:00
Nahuel ANGELINETTI
1a4e67c143 (bug #3183) fix the SetMarcUnicodeFlag function
This patch fix the funciton SetMarcUnicodeFlag for UNIMARC support, now the function will fix the length of the field, and set encoding as "50  " instead of "5050".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 08:23:14 -05:00
15d95fdd0e Optimize XSLT.pm
Avoid reading marc_tag_structure for each biblo record to
transform by XSLT. Not totaly useless on OPAC result page.
Should be done via application variables rather than
request variable, but this is another story.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:54:08 -05:00
98650328dd Add system preference search to administration home page (Bug 3181)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:49:41 -05:00
861ffc0109 Bugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]
Thanks G. Henry

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:39:59 -05:00
Galen Charlton
70b7017eca fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:32:02 -05:00
1d2ec60fbd Bug 2944 fix courtesy of Amr Denni
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:22:49 -05:00
Colin Campbell
e60fbf4c30 (bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:10:19 -05:00
f3d3b5e50c Spelling correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:07:56 -05:00
543f0a49ee Adding David Birmingham as a developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-08 07:07:54 -05:00
Colin Campbell
3b6c36a4f3 Moved some variable definitions out of conditionals
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 17:08:16 -05:00
Garry Collum
2eaf194268 Bug 3081 - The category code in the patron personal details page in opac showed the category code and not the description. This patch makes the description appear instead. Looking at both opac-userupdate.pl and opac-userupdate.tmpl, the actual value of this text box is not retrieved for any purpose.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:54:10 -05:00
Nahuel ANGELINETTI
1310c8e2ac (bug #3193) fix the comtd value in acqui-home.pl
this patch fix the value of the comtd value which is not the same as in bookfund.pl, clicking on the value from acqui-home.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:42:03 -05:00
Joe Atzberger
970fcce040 Remove duplicate assignments for $template->param(script_name)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:55 -05:00
Joe Atzberger
544b03357a Convert shelves from using "toggle" code
And one ELSIF.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:54 -05:00
Joe Atzberger
51a0e335d5 Bug 3157: IE compatibility for label display
Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-07 16:26:53 -05:00
d5359da551 Adding Colin Campbell to the history doc
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 18:35:27 -05:00
Galen Charlton
822ecbdc42 removed extra /TMPL_IF introduce in previous Syndetics patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:27:46 -05:00
David Birmingham
d5d21fe101 Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:18:27 -05:00
Chris Cormack
d32d5bfb9b Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 17:06:53 -05:00
Garry Collum
1eb9154b73 Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element.  The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank.  Added code to check for an empty string in the first
element.

You can test this by making salutation (title) mandatory.

Also fixed some typos in some of the comments.  Why?  Because I'm a Librarian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:47:09 -05:00
Nahuel ANGELINETTI
4dbe34f231 (bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:25:36 -05:00
Galen Charlton
a50c16bae2 new author test for syntax errors in HTML templates
Added a new author test to look for syntax errors
in the HTML templates.  Run by doing

prove xt/author/valid-templates.t

from the root of a Koha source tree.

This test will help catch the following errors:

* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
  cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag

This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:21:47 -05:00
Galen Charlton
1ecd369926 fix XHTML validation error introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:18:04 -05:00
Jane Wagner
f5be7dc8e4 Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:11:17 -05:00
Joe Atzberger
7a8e256263 Remove unused $toggle code
Some trivial other cleanups also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 16:02:30 -05:00
Chris Cormack
7c5ab1411b Adding the creation of sql library on the wiki
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:21:54 -05:00
Galen Charlton
53ace84401 Syndetics: add support for AVSUMMARY and AVPROFILE
Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:19:19 -05:00
Galen Charlton
050f9115de Syndetics: start switch to XML::LibXML to parse results
XML::Simple doesn't handle mixed content, which is a
problem because reviews provided by Syndetics sometimes
contain HTML tags.  Furthermore, it's often easier to write
XPath to extract bits of an XML document than trying
to play with XML::Simple's options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:17:24 -05:00
Galen Charlton
2e9d9d9d95 Syndetics: add fiction notes/title profile link
If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.

TODO: add a system preference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:17:22 -05:00
Colin Campbell
959d31b6a8 Correct comparison which was using an octal number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:57 -05:00
Chris Cormack
e71782159c Adding Liz Rea to the history.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:52 -05:00
Galen Charlton
631c7008f9 Syndetics: handle variations in reviews XML output
For some reason different Syndetics users get
slightly different results when requesting
an XML-formatted review, so it's necessary to
handle both observed variations:

Here's one variation:

...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
    <a>This is a review

And another:
...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
        This is a review

This patch fixes a bug where some users the
source of a review but not the review itself.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:45 -05:00
Galen Charlton
4d95af2968 fix to C4::Koha::_isbn_cleanup
Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:41 -05:00
root
99dd5db699 Verbiage clarification in intranet advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:30 -05:00
1f0c678d5c Fix for Bug 2767, cart and lists buttons missing on opac-search.pl
This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:26 -05:00
Liz Rea
2c5d971a96 Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:24 -05:00
Joe Atzberger
ccb64c18ee Bug 3177 - haspermission offers bogus option
$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:20 -05:00
Ryan Higgins
fa848a66f0 Bug 3179: Typo in C4::Circulation function call causes fatal error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-01 07:16:15 -05:00
Chris Cormack
1eb2ab5d9b Whoops I typo'd Garry's name - fixed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:38 -05:00
root
dd8ee0bbc6 Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:33 -05:00
Chris Cormack
68d80a62aa Updating history docs for new developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:31 -05:00
Liz Rea
69620d9479 Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 16:54:26 -05:00