Commit graph

9774 commits

Author SHA1 Message Date
Stephen Edwards
15c0ac756e bug 2991: Request hold on multiple items at one time.
Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.

Updated the request CGI scripts to handle multiple biblio items.

Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.

Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:52:39 -06:00
ffa3c9a4a1 Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:36:54 -06:00
Nahuel Angelinetti
e080066db4 bug 2772: bad image location
This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 09:07:46 -06:00
Nahuel ANGELINETTI
04f8382d5b (bug #2978) fix differents bugs in marc editor
This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:39:51 -06:00
Nahuel ANGELINETTI
72563b0449 (bug #2933) change popup names containing space chars
This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:37:30 -06:00
Henri-Damien LAURENT
1c14654c8e Using openAuth function for authorities Searching
Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:34:27 -06:00
Nahuel ANGELINETTI
aea15bca2a (bug #3011) csv export doesn't fill all the fields
This patch just fix the script which export to csv the overdue, and field the missing fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-06 08:00:15 -06:00
Nahuel Angelinetti
4f2557e46e bug 2840: Delete a hidden tag that is not needed and create an error
The bug exists because for each table line, an hidden field was set, with subscriptionid, but it's not used by the script and
create a bug "Request-URI Too Large".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 11:16:36 -06:00
Joe Atzberger
b0a1759e92 Bug 2883 - longoverdue cronjob fails to implement required functionality.
This does not fix all problems recorded in 2883 (see all the FIXME's), but
it does improve the script's basic feedback to an intelligible level.
It also adjusts the documentation and examples to correct bogus usage
instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 10:30:29 -06:00
Joe Atzberger
abe306c2df Allow LDAP test to bail if LDAP disabled.
Also added more feedback and the ability to override KOHA_CONF
"useldapserver" value with ENV variable KOHA_USELDAPSERVER.

This patch should be considered for inclusion to 3.0 stable branch
because it prevents unnecessary failure of test battery.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:49:10 -06:00
Nahuel ANGELINETTI
bda53debab (bug #2996) update unimarc 105 plugin to the actual norm
This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:23:08 -06:00
Nahuel ANGELINETTI
49a39b311a (bug #2996) fix and improve 100 and 105 unimarc plugins
This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 09:22:51 -06:00
Henri-Damien LAURENT
c1682628e9 Translating UNIMARC plugins in English
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 839c87a48c)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-05 08:53:01 -06:00
Daniel Sweeney
ab28085949 Added a require C4::Heading to resolve a circular dependency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:58:18 -06:00
Mason James
97b8acb06c - perltidy corrects broken indentation on 'if' block.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:27 -06:00
Mason James
edacb17ba6 bug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:23 -06:00
Mason James
41cb983c3b fix for bug-2923, corrects renew status in SCO
- removes unneeded  HTML::Template::Pro
 - some indent/newline tidies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 16:28:17 -06:00
Joe Atzberger
3d2ec1607d Trivial comment typos corrected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:57:24 -06:00
Nahuel ANGELINETTI
734cf78be6 Autoselect marcflavour in marc import
This patch is writted by Paul Poulain.
It auto-select the marcflavour from syspref in the stage marc import.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:57:22 -06:00
Joe Atzberger
1d1d69eafc Prevent warning if intranetuserjs is already NULL/undefined.
Warning would look like:
updatedatabase.pl: Use of uninitialized value in string eq
at /home/user/koha/installer/data/mysql/updatedatabase.pl line 2141.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:57:19 -06:00
Joe Atzberger
c41a8c0cfd Correct capitalization on CGI::Session::Serialize::yaml
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:54:20 -06:00
Nahuel ANGELINETTI
cfa2143b28 (bug #2917) editing authority marc field structure doesn't workl
This patch add a field in the ->execute() statement which was missing.
The sql request have 8 args, and only 7 was passed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:50:58 -06:00
Mason James
e9599f973c Fixes command-line 'number' arg in bulkauthimport.pl.
for HEAD and 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:43:49 -06:00
Nahuel ANGELINETTI
7fb039f6c0 (bug #2961) be xhtml valid
This little patch just fix the previous patch to be xhtml valid(onclick instead of onClick)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 10:25:53 -06:00
Nahuel ANGELINETTI
5397ab31dc (bug #2961) add a button to add manually the next issue
This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:55 -06:00
Nahuel ANGELINETTI
b48df4e32f (bug #2962) escape searchbox, and change the search from tag clouds
This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:40:50 -06:00
Chris Nighswonger
fede41b161 Kohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix
The current regexp used to split fiction call numbers does not handle the '.' char well. This patch corrects the regexp so that it behaves as expected.

This patch should be ported to the 3.0.x branch.

[fbcbug 5]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:32:08 -06:00
66b96f079a Adding Copy Number column to table of item information on holds pages.
Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 09:27:49 -06:00
Brian Harrington
25cd35b3a1 bug 2924 fixed rebuild_zebra.pl to work when export is skipped
reindexing now occurs if there are $num_records_exported or if
$skip_export is set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:28:22 -06:00
Galen Charlton
be82512f01 bug 2986: tweak authtype index for MARC21 (GRS-1)
Following a similar patch for UNIMARC, tweak the
authtype index for MARC21 authorities if the GRS-1
Zebra filter is in use.

Note that it is recommended that *DOM* mode indexing
be used for MARC21 authorities; if you're using DOM mode,
it is not necessary to rebuild the index.  However, if
you're using the GRS-1 definitions (record.abs), it will
be necessary to reindex the authority records using

misc/migration_tools/rebuild_zebra.pl -a -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:19:34 -06:00
259c77ed9b Fix bug #2986 - Authority search
On authorities-home.pl page, when you do search, you don't have any
result. Looking in log file, you see a Zebra error:

  Unsupported Use attribute (114) authtype Bib-1

This patch modify record.abs UNIMARC definition.
The same may have to be done for MARC21 record.abs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:32 -06:00
Mason James
f295d4d223 fixes missing 'STDERR', causing 500 error below..
malformed header from script. Bad header=## checkpw - checking LDAP: mainpage.pl,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:29 -06:00
Galen Charlton
d5faa7f114 bug 2992: don't display MARC codes in search results
Two fields (type of continuing resource and literary
form for sound recordings) in the MARC21 XSLT search
results stylesheet display the code from the 008
position (/21 and /31, respectively) in addition to a
descriptive label.  As a MARC code is meaningless to
patrons, this patch removes the code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:27 -06:00
Nahuel ANGELINETTI
b18f878c5e (bug #2998) fix search sorting containing "="
just modify the way to parse the actual args

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:24 -06:00
Nahuel ANGELINETTI
96634e77dc Update autobarcode syspref for french framework
This patch just update the syspref to use incremental|annual|hbyymmincr|OFF instead of "YesNo".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:07:21 -06:00
Nahuel ANGELINETTI
63d2fdd8c6 (bug #2995) Set a default encoding for e-mails
Just set a default encoding as utf8 if none is provided.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-04 08:02:03 -06:00
Galen Charlton
8f9618833e changes to OPAC results and detail XSLT
Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-27 15:21:45 -06:00
Galen Charlton
2026c28797 display library name instead of code in limit description
The OPAC and staff search results page will now display
the library name instead of the library code in the limit
part of the search description, e.g.,

"kw,wrdl: cat branch:Centerville" instead of
"kw,wrdl: cat branch:CPL"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-27 15:11:37 -06:00
90670970f6 Resubmitting: Change to how email link is displayed for on-hold items
Email link should only display when the on-hold item is being checked in at its destination branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 15:24:24 -06:00
Galen Charlton
b8d979abe7 minor corrections to check-url.pl
* removed ersataz YAML::XS dependency
* use 'return' instead of 'return undef'
* minor language changes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 15:21:14 -06:00
64505d7118 URLs checker enhancement (bug #2959)
Improve URLs checker script in the way (half way) pointed out by Galen:

- A C4::URL::Checker class handle URL checking. This class is not yet
  in a separate file in C4 directory. This class would be easily
  extended to accomodate authorities URLs checking.
- Script output can now be formatted in CSV or HTML. HTML version
  link directly to MARC biblio record editor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 15:06:22 -06:00
Joe Atzberger
3f54fb1961 Bug 2968 - SIP ACS_STATUS message (98) misreported config.
The *_ok methods in ILS.pm were targeting the wrong depth.
This also resolves a longstanding FIXME on to_bool() warning like:
    Argument "\x{66}\x{61}..." isn't numeric in numeric ne (!=) at /ILS.pm line 94.

The example_institution_dump.sh essentially provides the proof test case for this patch.
Run it before/after on SIPconfig.xml where "MAIN" has checkout="true" and checkin="true".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:57:22 -06:00
d5908e57c0 Adding additional information and consolidating display of information in holds queue report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:53:15 -06:00
Andrew Elwell
50533a1ad5 Consistency check between Makefile.pl and about.pl We weren't picking up JSOM so admin/item_circulation_alerts.pl gave a 500 internal server error if JOSM not installed.
Also sorted packages.debian alphabetically so that we can maintain
 easier.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:48:53 -06:00
Andrew Elwell
b49d937e2c more Minor documentation fixes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:45:58 -06:00
Andrew Elwell
e64f395d43 Minor documentation typos
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:45:46 -06:00
7dd4724670 Upgrade jquery dimensions plugin. Correction to Cart js to match.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:37:06 -06:00
d4ed156eb4 Adding information that patron is restricted/address in doubt to hold notification screen
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:23:39 -06:00
7d2875ae4d Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:21:52 -06:00
Galen Charlton
66d2e36fa3 bug 2988: apply correct hold policy
Item type was not retrieved in a query, leading to a case
where an item could be selected by build_holds_queue.pl
to fill a hold request even where forbidden by the
library and item type-level policy.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-26 14:14:46 -06:00